Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2286943002:
Remove confusing DLOG from SingletonHwnd (Closed)
DescriptionRemove confusing DLOG from SingletonHwnd
Sheriffs and general bug fixers often find this logspam confusing,
thinking it relevant to the problem at hand. However it's rare that the
actual perpetrator sees it when adding the problem. So keep the blocking
behaviour, but remove the log.
R=thakis@chromium.org
BUG=258201
Committed: https://crrev.com/9ea42589762af9cdd82c0ab08e4d939fb8efb417
Cr-Commit-Position: refs/heads/master@{#414824}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 14 (8 generated)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove confusing DLOG from SingleonHwnd Sheriffs and general bug fixers often find this logspam confusing, thinking it relevant to the problem at hand. However it's rare that the actual perpetrator sees it when adding the problem sees it when adding the problem. So keep the blocking behaviour, but remove the log. R=thakis@chromium.org BUG=258201 ========== to ========== Remove confusing DLOG from SingleonHwnd Sheriffs and general bug fixers often find this logspam confusing, thinking it relevant to the problem at hand. However it's rare that the actual perpetrator sees it when adding the problem. So keep the blocking behaviour, but remove the log. R=thakis@chromium.org BUG=258201 ==========
Description was changed from ========== Remove confusing DLOG from SingleonHwnd Sheriffs and general bug fixers often find this logspam confusing, thinking it relevant to the problem at hand. However it's rare that the actual perpetrator sees it when adding the problem. So keep the blocking behaviour, but remove the log. R=thakis@chromium.org BUG=258201 ========== to ========== Remove confusing DLOG from SingletonHwnd Sheriffs and general bug fixers often find this logspam confusing, thinking it relevant to the problem at hand. However it's rare that the actual perpetrator sees it when adding the problem. So keep the blocking behaviour, but remove the log. R=thakis@chromium.org BUG=258201 ==========
removing dlogs always lgtm https://codereview.chromium.org/2286943002/diff/1/ui/gfx/win/singleton_hwnd.cc File ui/gfx/win/singleton_hwnd.cc (left): https://codereview.chromium.org/2286943002/diff/1/ui/gfx/win/singleton_hwnd.c... ui/gfx/win/singleton_hwnd.cc:34: DLOG(ERROR) << "Cannot create windows on non-UI thread!"; could this be a CHECK?
https://codereview.chromium.org/2286943002/diff/1/ui/gfx/win/singleton_hwnd.cc File ui/gfx/win/singleton_hwnd.cc (left): https://codereview.chromium.org/2286943002/diff/1/ui/gfx/win/singleton_hwnd.c... ui/gfx/win/singleton_hwnd.cc:34: DLOG(ERROR) << "Cannot create windows on non-UI thread!"; On 2016/08/26 21:21:37, Nico wrote: > could this be a CHECK? No :( happens all the time (currently) in poorly factored code that runs in all processes semi-accidentally. Someday, ideally though, yes.
The CQ bit was unchecked by scottmg@chromium.org
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove confusing DLOG from SingletonHwnd Sheriffs and general bug fixers often find this logspam confusing, thinking it relevant to the problem at hand. However it's rare that the actual perpetrator sees it when adding the problem. So keep the blocking behaviour, but remove the log. R=thakis@chromium.org BUG=258201 ========== to ========== Remove confusing DLOG from SingletonHwnd Sheriffs and general bug fixers often find this logspam confusing, thinking it relevant to the problem at hand. However it's rare that the actual perpetrator sees it when adding the problem. So keep the blocking behaviour, but remove the log. R=thakis@chromium.org BUG=258201 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove confusing DLOG from SingletonHwnd Sheriffs and general bug fixers often find this logspam confusing, thinking it relevant to the problem at hand. However it's rare that the actual perpetrator sees it when adding the problem. So keep the blocking behaviour, but remove the log. R=thakis@chromium.org BUG=258201 ========== to ========== Remove confusing DLOG from SingletonHwnd Sheriffs and general bug fixers often find this logspam confusing, thinking it relevant to the problem at hand. However it's rare that the actual perpetrator sees it when adding the problem. So keep the blocking behaviour, but remove the log. R=thakis@chromium.org BUG=258201 Committed: https://crrev.com/9ea42589762af9cdd82c0ab08e4d939fb8efb417 Cr-Commit-Position: refs/heads/master@{#414824} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9ea42589762af9cdd82c0ab08e4d939fb8efb417 Cr-Commit-Position: refs/heads/master@{#414824} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
