Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2286883003: Use Android Junit Runner for webview ui test (Closed)

Created:
4 years, 3 months ago by aluo
Modified:
4 years, 3 months ago
CC:
mikecase (-- gone --), android-webview-reviews_chromium.org, chromium-reviews, Yoland Yan(Google)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Android Junit Runner for webview ui test BUG=641594 Committed: https://crrev.com/86542fbf867af17e24b8b05dc88b7131a6725342 Cr-Commit-Position: refs/heads/master@{#416427}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed Mike's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M android_webview/tools/automated_ui_tests/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/tools/automated_ui_tests/javatests/AndroidManifest.xml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
mikecase (-- gone --)
lgtm w/ comment https://codereview.chromium.org/2286883003/diff/1/android_webview/tools/automated_ui_tests/BUILD.gn File android_webview/tools/automated_ui_tests/BUILD.gn (right): https://codereview.chromium.org/2286883003/diff/1/android_webview/tools/automated_ui_tests/BUILD.gn#newcode49 android_webview/tools/automated_ui_tests/BUILD.gn:49: "//base:base_java", Doesn't look like you need ...
4 years, 3 months ago (2016-09-01 16:26:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286883003/20001
4 years, 3 months ago (2016-09-03 00:52:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-03 02:34:38 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 02:36:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86542fbf867af17e24b8b05dc88b7131a6725342
Cr-Commit-Position: refs/heads/master@{#416427}

Powered by Google App Engine
This is Rietveld 408576698