Provide TaskRunner to ContextCacheController

ui/compositor/test/in_process_context_provider.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/test/in_process_context_provider.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/lazy_instance.h"
 #include "base/macros.h"
@@ skipping 72 matching lines @@
   // This is called on the thread the context will be used.
   DCHECK(context_thread_checker_.CalledOnValidThread());
 
   if (!context_) {
     context_.reset(gpu::GLInProcessContext::Create(
         nullptr,  /* service */
         nullptr,  /* surface */
         !window_, /* is_offscreen */
         window_, (shared_context_ ? shared_context_->context_.get() : nullptr),
         attribs_, gpu::SharedMemoryLimits(), gpu_memory_buffer_manager_,
-        image_factory_));
+        image_factory_, nullptr /* task_runner */));

[danakj, 2016/09/19 18:59:17]

I think you should pass non-null cuz otherwise if a test does lose context in
future it'll just crash. Null was meant to be for the |surface| isn't null case
right?

[ericrk, 2016/09/19 20:00:27]

Yeah - fair enough - I was thinking this was fine as long as tests don't use it,
but you're right, it's quite brittle.

 
     if (!context_)
       return false;
 
-    cache_controller_.reset(
-        new cc::ContextCacheController(context_->GetImplementation()));
+    cache_controller_.reset(new cc::ContextCacheController(
+        context_->GetImplementation(), nullptr /* task_runner */));
   }
 
   std::string unique_context_name =
       base::StringPrintf("%s-%p", debug_name_.c_str(), context_.get());
   context_->GetImplementation()->TraceBeginCHROMIUM(
       "gpu_toplevel", unique_context_name.c_str());
 
   return true;
 }
 
@@ skipping 54 matching lines @@
 uint32_t InProcessContextProvider::GetCopyTextureInternalFormat() {
   if (attribs_.alpha_size > 0)
     return GL_RGBA;
   DCHECK_NE(attribs_.red_size, 0);
   DCHECK_NE(attribs_.green_size, 0);
   DCHECK_NE(attribs_.blue_size, 0);
   return GL_RGB;
 }
 
 }  // namespace ui