Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1673)

Issue 2286843003: Add metrics for tracking underflow during src= playback. (Closed)

Created:
4 years, 3 months ago by DaleCurtis
Modified:
4 years, 3 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add metrics for tracking underflow during src= playback. I'm surprised we didn't already have these metrics, they are pretty key to evaluating improvements to our pipeline. Possibly they were harder to add prior to chcunningham@'s recent work to expose the BUFFERING_HAVE_NOTHING state to WMPI. BUG=641633 TEST=manual. Committed: https://crrev.com/9d638a1ee2933e62dccaed16eef64e64cbe2ded9 Cr-Commit-Position: refs/heads/master@{#415215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M media/blink/webmediaplayer_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 3 chunks +17 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
DaleCurtis
4 years, 3 months ago (2016-08-27 00:27:43 UTC) #2
chcunningham
Just a reminder, in addition to network underflow this will also be triggered whenever our ...
4 years, 3 months ago (2016-08-29 17:24:25 UTC) #3
DaleCurtis
holte@ ping?
4 years, 3 months ago (2016-08-29 21:19:24 UTC) #4
Steven Holte
lgtm
4 years, 3 months ago (2016-08-29 22:34:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286843003/1
4 years, 3 months ago (2016-08-29 23:30:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 06:21:15 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:24:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d638a1ee2933e62dccaed16eef64e64cbe2ded9
Cr-Commit-Position: refs/heads/master@{#415215}

Powered by Google App Engine
This is Rietveld 408576698