Convert RTCIceCandidate.html from js-test to testharness.js

Convert RTCIceCandidate.html from js-test to testharness.js

Trying to look for patterns we can potentially use for auto-converting these tests. See https://docs.google.com/a/google.com/document/d/1Ejzic4va3B0jam7D0AkrLbmhE57ZD06oeCZnSSiiTl8/edit?usp=sharing for what we've come up with so far.

BUG=614963

[jeffcarp, 2016-08-26 18:24:24]

jeffcarp@chromium.org changed reviewers:
+ guidou@chromium.org, qyearsley@chromium.org

[jeffcarp, 2016-08-26 21:26:46]

Description was changed from

==========
Convert RTCIceCandidate.html from js-test to testharness.js

Trying to look for patterns we can potentially use for auto-converting these
tests.

BUG=614963
==========

to

==========
Convert RTCIceCandidate.html from js-test to testharness.js

Trying to look for patterns we can potentially use for auto-converting these
tests. See
https://docs.google.com/a/google.com/document/d/1Ejzic4va3B0jam7D0AkrLbmhE57Z...
for what we've come up with so far.

BUG=614963
==========

[qyearsley, 2016-08-26 21:34:05]

https://codereview.chromium.org/2286833002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/peerconnection/RTCIceCandidate.html
(right):

https://codereview.chromium.org/2286833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCIceCandidate.html:32:
assert_throws('TypeMismatchError', () => new RTCIceCandidate({}));
This is the first time I've seen ES6 arrow functions! Pretty neat. I guess we
can assume that ES6 is OK because this is being used to test ToT Chrome (and if
it's upstreamed to web-platform-tests then it will also be used to test newer
browsers)?

https://codereview.chromium.org/2286833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCIceCandidate.html:35:
assert_throws('TypeMismatchError', () => new RTCIceCandidate({candidate: ''}));
Should these asserts be inside of a function passed to test()?

https://codereview.chromium.org/2286833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCIceCandidate.html:37:
test(() => new RTCIceCandidate({candidate: 'x'}));
To make it explicit that we're expecting no exception to be raised, you could
add a test description.
test(() => new RTCIceCandidate({candidate: 'x'}),
 'Constructor does not throw exception when given valid args');

https://codereview.chromium.org/2286833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCIceCandidate.html:52: });
Although, it wasn't in the original code, if we could figure out what these are
supposed to be testing, then perhaps a test description string could be added;
but if it's unclear then it's a good idea to leave it empty.

[qyearsley, 2016-08-26 23:00:50]

LGTM; should wait for guidou@ to take a look :-)

[jeffcarp, 2016-08-26 23:08:02]

On 2016/08/26 at 23:00:50, qyearsley wrote:
> LGTM; should wait for guidou@ to take a look :-)

Sounds good. I just pushed a patch to change the indentation from 2 to 4 spaces
to match the style guide.

[Guido Urdaneta, 2016-08-29 10:08:04]

On 2016/08/26 23:08:02, jeffcarp wrote:
> On 2016/08/26 at 23:00:50, qyearsley wrote:
> > LGTM; should wait for guidou@ to take a look :-)
> 
> Sounds good. I just pushed a patch to change the indentation from 2 to 4
spaces
> to match the style guide.

lgtm

[jeffcarp, 2016-08-29 14:50:28]

The CQ bit was checked by jeffcarp@chromium.org

[jeffcarp, 2016-08-29 14:50:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org
Link to the patchset: https://codereview.chromium.org/2286833002/#ps40001
(title: "Change from 2 to 4 space indentation to match Chromium style")

[commit-bot: I haz the power, 2016-08-29 14:50:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 17:00:46]

Description was changed from

==========
Convert RTCIceCandidate.html from js-test to testharness.js

Trying to look for patterns we can potentially use for auto-converting these
tests. See
https://docs.google.com/a/google.com/document/d/1Ejzic4va3B0jam7D0AkrLbmhE57Z...
for what we've come up with so far.

BUG=614963
==========

to

==========
Convert RTCIceCandidate.html from js-test to testharness.js

Trying to look for patterns we can potentially use for auto-converting these
tests. See
https://docs.google.com/a/google.com/document/d/1Ejzic4va3B0jam7D0AkrLbmhE57Z...
for what we've come up with so far.

BUG=614963

Committed: https://crrev.com/ab9f0606af0e7f6968c15e94dcd31f2e2053b948
Cr-Commit-Position: refs/heads/master@{#415020}
==========

[commit-bot: I haz the power, 2016-08-29 17:00:47]

Patchset 3 (id:??) landed as
https://crrev.com/ab9f0606af0e7f6968c15e94dcd31f2e2053b948
Cr-Commit-Position: refs/heads/master@{#415020}

[commit-bot: I haz the power, 2016-08-29 17:01:00]

Description was changed from

==========
Convert RTCIceCandidate.html from js-test to testharness.js

Trying to look for patterns we can potentially use for auto-converting these
tests. See
https://docs.google.com/a/google.com/document/d/1Ejzic4va3B0jam7D0AkrLbmhE57Z...
for what we've come up with so far.

BUG=614963

Committed: https://crrev.com/ab9f0606af0e7f6968c15e94dcd31f2e2053b948
Cr-Commit-Position: refs/heads/master@{#415020}
==========

to

==========
Convert RTCIceCandidate.html from js-test to testharness.js

Trying to look for patterns we can potentially use for auto-converting these
tests. See
https://docs.google.com/a/google.com/document/d/1Ejzic4va3B0jam7D0AkrLbmhE57Z...
for what we've come up with so far.

BUG=614963
==========

[commit-bot: I haz the power, 2016-08-29 17:01:00]

Committed patchset #3 (id:40001)