Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2286803002: [ios] Do not reset SSL status if load was cancelled. (Closed)

Created:
4 years, 3 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 3 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Do not reset SSL status if load was cancelled. SSL status needs to be reset if navigation fails with error. But back-forward navigation calls navigation failure callback with "cancelled" error. In this case SSL status should not be changed. The other case where navigation failure callback is called with cancelled error is load cancellation which should not reset SSL status as well. BUG=637832 Committed: https://crrev.com/96356608c5b12175d9859df19ed0baaa55371b76 Cr-Commit-Position: refs/heads/master@{#414763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Eugene But (OOO till 7-30)
4 years, 3 months ago (2016-08-26 17:34:51 UTC) #2
kkhorimoto
lgtm
4 years, 3 months ago (2016-08-26 17:45:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286803002/1
4 years, 3 months ago (2016-08-26 17:46:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 18:51:10 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 19:16:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96356608c5b12175d9859df19ed0baaa55371b76
Cr-Commit-Position: refs/heads/master@{#414763}

Powered by Google App Engine
This is Rietveld 408576698