Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 22868004: Transitions from DOUBLE to FAST were not checking for allocation site info. (Closed)

Created:
7 years, 3 months ago by mvstanton
Modified:
7 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Transitions from DOUBLE to FAST were not checking for allocation site info. This creates a confusing result. It's better to let allocation sites transition to their end state than artificially stop tracking at the double/fast boundary. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16820

Patch Set 1 #

Patch Set 2 : Comment update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -16 lines) Patch
M src/objects.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M test/mjsunit/allocation-site-info.js View 1 2 chunks +9 lines, -14 lines 0 comments Download
M test/mjsunit/array-literal-feedback.js View 1 2 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Toon, If you get a chance tomorrow or so to have a quick look. ...
7 years, 3 months ago (2013-08-26 14:18:04 UTC) #1
Toon Verwaest
lgtm
7 years, 3 months ago (2013-09-18 15:04:36 UTC) #2
mvstanton
7 years, 3 months ago (2013-09-19 09:48:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16820 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698