Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 22868002: Add constant for Sync OAuth2 scope (Closed)

Created:
7 years, 4 months ago by nyquist
Modified:
7 years, 4 months ago
Reviewers:
Raghu Simha, pavely
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add constant for Sync OAuth2 scope This deprecates the use of clientlogin scope, and adds the new OAuth2 scope to a Java constant. BUG=264503 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217827

Patch Set 1 #

Patch Set 2 : Add reference to GaiaConstants::kChromeSyncOAuth2Scope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M sync/android/java/src/org/chromium/sync/notifier/SyncStatusHelper.java View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nyquist
pavely: PTAL
7 years, 4 months ago (2013-08-12 16:02:37 UTC) #1
pavely
On 2013/08/12 16:02:37, nyquist wrote: > pavely: PTAL LGTM, but I'm not in OWNERS.
7 years, 4 months ago (2013-08-12 17:28:42 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 4 months ago (2013-08-15 08:34:47 UTC) #3
nyquist
rsimha: PTAL
7 years, 4 months ago (2013-08-15 17:29:13 UTC) #4
Raghu Simha
Rubberstamp LGTM.
7 years, 4 months ago (2013-08-15 17:34:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/22868002/4001
7 years, 4 months ago (2013-08-15 17:44:54 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=160374
7 years, 4 months ago (2013-08-15 18:52:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/22868002/4001
7 years, 4 months ago (2013-08-15 19:09:31 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-15 19:09:42 UTC) #9
Message was sent while issue was closed.
Change committed as 217827

Powered by Google App Engine
This is Rietveld 408576698