Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2286793002: Added a use counter for in-body external stylesheets (Closed)

Created:
4 years, 3 months ago by Pat Meenan
Modified:
4 years, 3 months ago
Reviewers:
esprehn, Mike West
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added a use counter for in-body external stylesheets This will give us an idea for how common it is to have in-body external stylesheets and gauge the impact of making them not block paint or determine if we need stronger protection like blocking the HTML parser. BUG=481122, 638074 Committed: https://crrev.com/d9d7833ff2b2d90cb54bd5cd184c00c58e2ac787 Cr-Commit-Position: refs/heads/master@{#415792}

Patch Set 1 #

Patch Set 2 : Merge with master (feature number collided) #

Patch Set 3 : Fixed trivial unit test link issue (symbol export) #

Patch Set 4 : Merge to master (feature enum collision again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngineContext.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/StyleEngineContext.cpp View 2 chunks +16 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Pat Meenan
esprehn@chromium.org: PTAL mkwst@chromium.org: Please review changes in histograms.xml
4 years, 3 months ago (2016-08-26 17:06:33 UTC) #2
esprehn
lgtm
4 years, 3 months ago (2016-08-30 21:27:38 UTC) #3
Mike West
LGTM.
4 years, 3 months ago (2016-08-31 13:16:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286793002/20001
4 years, 3 months ago (2016-08-31 14:18:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/121493)
4 years, 3 months ago (2016-08-31 15:08:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286793002/60001
4 years, 3 months ago (2016-08-31 19:23:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/121702) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-08-31 19:26:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286793002/100001
4 years, 3 months ago (2016-08-31 21:05:24 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years, 3 months ago (2016-08-31 23:03:55 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 23:05:21 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d9d7833ff2b2d90cb54bd5cd184c00c58e2ac787
Cr-Commit-Position: refs/heads/master@{#415792}

Powered by Google App Engine
This is Rietveld 408576698