Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2286733002: Add imagemasksubset GM (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : comment #

Patch Set 3 : sk_tool_utils.h #

Patch Set 4 : serialize-8888 supression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -1 line) Patch
A gm/imagemasksubset.cpp View 1 2 1 chunk +84 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-AndroidOne-GPU-Mali400MP2-Arm7-Release.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Debug.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus10-GPU-MaliT604-Arm7-Release.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Debug.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus9-CPU-Denver-Arm64-Debug.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-NexusPlayer-CPU-SSE4-x86-Release.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug-CommandBuffer.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 1 2 3 3 chunks +12 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-GPU-GTX960-x86_64-Debug-ANGLE.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/adb_in_path.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/big_issue_number.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_skimage.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_skps.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_svgs.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_dm.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_get_hashes.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SKP_VERSION_device.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SVG_VERSION_device.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/recipe_with_gerrit_patch.json View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
f(malita)
Currently fails for anything != SkImage_Gpu.
4 years, 3 months ago (2016-08-26 15:29:24 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/2286733002/diff/1/gm/imagemasksubset.cpp File gm/imagemasksubset.cpp (right): https://codereview.chromium.org/2286733002/diff/1/gm/imagemasksubset.cpp#newcode12 gm/imagemasksubset.cpp:12: #include "SkSurface.h" How are you getting by without ...
4 years, 3 months ago (2016-08-26 15:38:00 UTC) #5
f(malita)
https://codereview.chromium.org/2286733002/diff/1/gm/imagemasksubset.cpp File gm/imagemasksubset.cpp (right): https://codereview.chromium.org/2286733002/diff/1/gm/imagemasksubset.cpp#newcode12 gm/imagemasksubset.cpp:12: #include "SkSurface.h" On 2016/08/26 15:38:00, robertphillips wrote: > How ...
4 years, 3 months ago (2016-08-26 15:58:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286733002/40001
4 years, 3 months ago (2016-08-26 15:58:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/11075)
4 years, 3 months ago (2016-08-26 16:12:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286733002/60001
4 years, 3 months ago (2016-08-26 16:45:01 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 17:13:43 UTC) #18
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/ce2fc6a045ea9ca1b0d78b2df793296d4e0cb3b3

Powered by Google App Engine
This is Rietveld 408576698