Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2286723003: Split fpdf_text_int into classes (Closed)

Created:
4 years, 3 months ago by npm
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move the classes in fpdf_text_int.cpp into their own files - CPDF_TextPageFind and CPDF_LinkExtract moved to new file - fpdf_text_int.cpp renamed to be CPDF_TextPage definition Committed: https://pdfium.googlesource.com/pdfium/+/2d396ac157bcd6da78190def936e5eaf278a6ca7

Patch Set 1 #

Patch Set 2 : Fix bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+605 lines, -2752 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
A core/fpdftext/cpdf_linkextract.cpp View 1 chunk +173 lines, -0 lines 0 comments Download
A + core/fpdftext/cpdf_textpage.cpp View 4 chunks +2 lines, -602 lines 0 comments Download
A core/fpdftext/cpdf_textpagefind.cpp View 1 1 chunk +407 lines, -0 lines 0 comments Download
D core/fpdftext/fpdf_text_int.cpp View 1 chunk +0 lines, -2149 lines 0 comments Download
M core/fpdftext/include/cpdf_textpage.h View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
npm
PTAL
4 years, 3 months ago (2016-08-26 16:03:57 UTC) #9
Lei Zhang
lgtm
4 years, 3 months ago (2016-08-26 16:53:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286723003/20001
4 years, 3 months ago (2016-08-26 17:00:07 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 17:00:28 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/2d396ac157bcd6da78190def936e5eaf278a...

Powered by Google App Engine
This is Rietveld 408576698