Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2286703002: Ntp: delete dead code and fix broken JavaDoc. (Closed)

Created:
4 years, 3 months ago by Michael van Ouwerkerk
Modified:
4 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ntp: delete dead code and fix broken JavaDoc. Committed: https://crrev.com/c264db894cd16183a3d1bf02dad9f4c7f00631ab Cr-Commit-Position: refs/heads/master@{#415313}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentlyClosedBridge.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Michael van Ouwerkerk
Nicolas, could you take a look please?
4 years, 3 months ago (2016-08-26 13:11:35 UTC) #4
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 3 months ago (2016-08-26 15:59:02 UTC) #8
Bernhard Bauer
lgtm
4 years, 3 months ago (2016-08-26 16:01:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286703002/20001
4 years, 3 months ago (2016-08-30 15:36:40 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 16:21:15 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 16:22:50 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c264db894cd16183a3d1bf02dad9f4c7f00631ab
Cr-Commit-Position: refs/heads/master@{#415313}

Powered by Google App Engine
This is Rietveld 408576698