chrome/browser/ui/cocoa/apps/app_menu_controller_mac.h - Issue 22867009: Swap main menu with app-specific menu when app window focused.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/apps/app_menu_controller_mac.h

Issue 22867009: Swap main menu with app-specific menu when app window focused. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/app_controller_mac.mm ('K') | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/ui/cocoa/apps/app_menu_controller_mac.mm » ('j') | chrome/browser/ui/cocoa/apps/app_menu_controller_mac.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
	tapted 2013/08/15 04:39:23 nit: no (c) nit: no (c) jackhou1 2013/08/16 02:50:41 Done. Show quoted text On 2013/08/15 04:39:23, tapted wrote: > nit: no (c) Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_COCOA_APPS_APP_MENU_CONTROLLER_MAC_H_

	6 #define CHROME_BROWSER_UI_COCOA_APPS_APP_MENU_CONTROLLER_MAC_H_

	7

	8 #import <Cocoa/Cocoa.h>

	9

	10 #include "base/mac/scoped_nsobject.h"

	11

	12 // This controller listens to NSWindowDidBecomeMainNotification and

	13 // NSWindowDidResignMainNotification and modifies the main menu bar to mimic a

	14 // main menu for the app. When an app window becomes main, all Chrome menu items

	15 // are hidden and menu items for the app are appended to the main menu. When the

	16 // app window resigns main, its menu items are removed and all Chrome menu items

	17 // are unhidden.

	18 @interface AppMenuController : NSObject {

	19 @private

	20 // The app id of the currently focused packaged app.
	tapted 2013/08/15 04:39:23 nit: maybe in the comment call it an extension id nit: maybe in the comment call it an extension id in case someone thinks there's a different id namespace for apps.. jackhou1 2013/08/16 02:50:41 Done. Show quoted text On 2013/08/15 04:39:23, tapted wrote: > nit: maybe in the comment call it an extension id in case someone thinks there's > a different id namespace for apps.. Done.
	21 base::scoped_nsobject<NSString> appId_;

	22 // An array of items related to the currently focused packaged app.

	23 base::scoped_nsobject<NSMutableArray> appMenuItems_;
	tapted 2013/08/15 04:39:23 I think until we add multiple items, this should j I think until we add multiple items, this should just be a single NSMenuItem rather han an array. jackhou1 2013/08/16 02:50:41 Done. Show quoted text On 2013/08/15 04:39:23, tapted wrote: > I think until we add multiple items, this should just be a single NSMenuItem > rather han an array. Done.
	24 }

	25

	26 - (id)init;
	tapted 2013/08/15 04:39:23 Don't need to redeclare this, since you inherit th Don't need to redeclare this, since you inherit the dec from NSObject. jackhou1 2013/08/16 02:50:41 Done. Show quoted text On 2013/08/15 04:39:23, tapted wrote: > Don't need to redeclare this, since you inherit the dec from NSObject. Done.
	27

	28 @end

	29

	30 #endif // CHROME_BROWSER_UI_COCOA_APPS_APP_MENU_CONTROLLER_MAC_H_

OLD	NEW