Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2286653002: Remove most things GYP. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
pdfium-reviews_googlegroups.com, brettw
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3525 lines) Patch
M DEPS View 1 2 chunks +1 line, -6 lines 0 comments Download
D build_gyp/all.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D build_gyp/gyp_pdfium View 1 chunk +0 lines, -71 lines 0 comments Download
D build_gyp/gyp_pdfium.py View 1 chunk +0 lines, -8 lines 0 comments Download
D build_gyp/set_clang_warning_flags.gypi View 1 chunk +0 lines, -58 lines 0 comments Download
D build_gyp/standalone.gypi View 1 1 chunk +0 lines, -591 lines 0 comments Download
D pdfium.gyp View 1 1 chunk +0 lines, -1176 lines 0 comments Download
D samples/samples.gyp View 1 chunk +0 lines, -100 lines 0 comments Download
D testing/gmock.gyp View 1 chunk +0 lines, -57 lines 0 comments Download
D testing/gtest.gyp View 1 chunk +0 lines, -175 lines 0 comments Download
D testing/libfuzzer/fuzzers.gyp View 1 chunk +0 lines, -171 lines 0 comments Download
D third_party/third_party.gyp View 1 chunk +0 lines, -477 lines 0 comments Download
D xfa.gyp View 1 chunk +0 lines, -618 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Lei Zhang
Is it time?
4 years, 3 months ago (2016-08-26 16:30:48 UTC) #6
Dirk Pranke
Seems like it's fine to start this for the deps-ed in stuff. Brett and I ...
4 years, 3 months ago (2016-08-26 17:58:19 UTC) #7
Dirk Pranke
lgtm.
4 years, 3 months ago (2016-08-26 17:58:27 UTC) #8
Lei Zhang
On 2016/08/26 17:58:19, Dirk Pranke wrote: > Seems like it's fine to start this for ...
4 years, 3 months ago (2016-08-26 21:09:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286653002/20001
4 years, 3 months ago (2016-08-26 21:39:14 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 21:39:37 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/b7fb1fd087cfe20cfc29cabc80af2c11e915...

Powered by Google App Engine
This is Rietveld 408576698