Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2286623002: Remove chrome_app_unittests from chromium_builder_dbg_drmemory_win target (Closed)

Created:
4 years, 3 months ago by Alexander Potapenko
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove chrome_app_unittests from chromium_builder_dbg_drmemory_win target This should probably fix the compile step on the Dr. Memory builder. BUG=640185 TBR=dpranke@chromium.org,cpu@chromium.org NOTRY=true Committed: https://crrev.com/48586ee56e601e60095f30723060d4bd888ce6fe Cr-Commit-Position: refs/heads/master@{#414670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Alexander Potapenko
TBR
4 years, 3 months ago (2016-08-26 07:55:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286623002/1
4 years, 3 months ago (2016-08-26 07:56:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 08:00:14 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/48586ee56e601e60095f30723060d4bd888ce6fe Cr-Commit-Position: refs/heads/master@{#414670}
4 years, 3 months ago (2016-08-26 08:03:41 UTC) #6
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-26 17:59:00 UTC) #7
tommycli
4 years, 3 months ago (2016-09-16 17:21:58 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2341353002/ by tommycli@chromium.org.

The reason for reverting is: Reverting, because Dr. Memory test bots need that
executable. It didn't break until a clobber landed and deleted the executable
generated in the past.

Also glider@ reports that chrome_app_unittests was probably innocent (in the bug
report) anyways.

First breaking build:
https://build.chromium.org/p/chromium.memory.full/builders/Windows%20Unit%20%....

Powered by Google App Engine
This is Rietveld 408576698