Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2286613002: [heap] MemoryChunk cleanup (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] MemoryChunk cleanup BUG= R=ulan@chromium.org Committed: https://crrev.com/b15bda38a665965868e156c6b4a2365c289f26ab Cr-Commit-Position: refs/heads/master@{#39054}

Patch Set 1 #

Patch Set 2 : Forgot platforms #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -97 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/heap/spaces.h View 1 2 10 chunks +57 lines, -67 lines 0 comments Download
M src/heap/spaces.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Michael Lippautz
ptal
4 years, 3 months ago (2016-08-31 11:37:24 UTC) #11
ulan
nice, lgtm!
4 years, 3 months ago (2016-08-31 12:19:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286613002/40001
4 years, 3 months ago (2016-08-31 19:43:29 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-31 19:45:33 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 19:45:50 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b15bda38a665965868e156c6b4a2365c289f26ab
Cr-Commit-Position: refs/heads/master@{#39054}

Powered by Google App Engine
This is Rietveld 408576698