Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 22866018: valgrind: Fix running webkit-tests. (Closed)

Created:
7 years, 4 months ago by sadrul
Modified:
7 years, 4 months ago
Reviewers:
Lei Zhang, Dirk Pranke
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

valgrind: Fix running webkit-tests. webkit layout tests do not set the PATH when running layout-tests anymore. So include the while path in the wrapper. BUG=277078 R=dpranke@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/valgrind/chrome_tests.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/valgrind_test.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
lgtm.
7 years, 4 months ago (2013-08-21 23:27:01 UTC) #1
sadrul
Thanks! +thestig@chromium.org for OWNERS
7 years, 4 months ago (2013-08-21 23:28:34 UTC) #2
Lei Zhang
lgtm++
7 years, 4 months ago (2013-08-21 23:57:48 UTC) #3
sadrul
7 years, 4 months ago (2013-08-22 02:25:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r218903 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698