Make cc::SoftwareImageDecodeController, cc::ResourcePool, and cc::StagingBufferPoo…

cc/resources/resource_pool.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/resource_pool.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 52 matching lines @@
       max_memory_usage_bytes_(0),
       max_resource_count_(0),
       in_use_memory_usage_bytes_(0),
       total_memory_usage_bytes_(0),
       total_resource_count_(0),
       task_runner_(task_runner),
       evict_expired_resources_pending_(false),
       resource_expiration_delay_(expiration_delay),
       weak_ptr_factory_(this) {
   base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
       this, "cc::ResourcePool", task_runner_.get());

[tasak, 2016/08/26 10:08:04]

Need to register this with ChildMemoryCoordinator here.

 }
 
 ResourcePool::~ResourcePool() {
   base::trace_event::MemoryDumpManager::GetInstance()->UnregisterDumpProvider(
       this);
 
   DCHECK_EQ(0u, in_use_resources_.size());
 
   while (!busy_resources_.empty()) {
     DidFinishUsingResource(PopBack(&busy_resources_));
   }
 
   SetResourceUsageLimits(0, 0);
   DCHECK_EQ(0u, unused_resources_.size());
   DCHECK_EQ(0u, in_use_memory_usage_bytes_);
   DCHECK_EQ(0u, total_memory_usage_bytes_);
   DCHECK_EQ(0u, total_resource_count_);

[tasak, 2016/08/26 10:08:04]

Need to unregister this with ChildMemoryCoordinator here.

 }
 
 Resource* ResourcePool::ReuseResource(const gfx::Size& size,
                                       ResourceFormat format,
                                       const gfx::ColorSpace& color_space) {
   // Finding resources in |unused_resources_| from MRU to LRU direction, touches
   // LRU resources only if needed, which increases possibility of expiring more
   // LRU resources within kResourceExpirationDelayMs.
   for (ResourceDeque::iterator it = unused_resources_.begin();
        it != unused_resources_.end(); ++it) {
@@ skipping 345 matching lines @@
   }
   for (const auto& resource : busy_resources_) {
     resource->OnMemoryDump(pmd, resource_provider_, false /* is_free */);
   }
   for (const auto& entry : in_use_resources_) {
     entry.second->OnMemoryDump(pmd, resource_provider_, false /* is_free */);
   }
   return true;
 }
 
+void ResourcePool::OnMemoryStateChange(
+    memory_coordinator::mojom::MemoryState state) {
+  if (state == memory_coordinator::mojom::MemoryState::SUSPENDED) {
+    while (!unused_resources_.empty())
+      DeleteResource(PopBack(&unused_resources_));

[ericrk, 2016/08/31 17:50:32]

This doesn't free "busy" resources, which can safely be released. Prefer:
EvictResourcesNotUsedSince(base::TimeTicks() + base::TimeDelta::Max());

+  }
+}
+
 }  // namespace cc