Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2286573002: Revert "Stop SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar from using TextCheckingParagrah" (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Stop SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar from using TextCheckingParagrah" This is a manual revert of commit 41165826c11cc0b7f1457b4c455d7e2eb2de0819, due to causing performance regression. Original issue's description: > Stop SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar from using TextCheckingParagrah > > SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar() does not really need > a TextCheckingParagraph as its parameter; an EphemeralRange of text to check is > sufficient. > > Hence, this patch changes its parameter from a TextCheckingParagraph to an > EphemeralRange, simplifying code and improving performance by eliminating the > overhead for finding the paragraph containing the text to be checked. > > BUG=n/a > TEST=n/a; no visible change > > Committed: https://crrev.com/41165826c11cc0b7f1457b4c455d7e2eb2de0819 > Cr-Commit-Position: refs/heads/master@{#414328} BUG=641083 TBR=yosin@chromium.org Committed: https://crrev.com/081b3356bbea770e05fa19c2947e67b9916b5786 Cr-Commit-Position: refs/heads/master@{#414675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 2 chunks +18 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286573002/1
4 years, 3 months ago (2016-08-26 02:07:01 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/281686)
4 years, 3 months ago (2016-08-26 05:25:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286573002/1
4 years, 3 months ago (2016-08-26 06:15:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 08:58:11 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 09:00:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/081b3356bbea770e05fa19c2947e67b9916b5786
Cr-Commit-Position: refs/heads/master@{#414675}

Powered by Google App Engine
This is Rietveld 408576698