Add credit card scanner to payments UI.

Add credit card scanner to payments UI.

The credit card scanner UI is behind the
chrome://flags#scan-cards-in-web-payments flag until UI behavior is
polished.

BUG=640430
Committed: https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8
Cr-Commit-Position: refs/heads/master@{#417709}

[please use gerrit instead, 2016-09-09 01:08:08]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 01:08:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-09-09 01:09:42]

Description was changed from

==========
Add credit card scanner to payments UI.

BUG=640430
==========

to

==========
Add credit card scanner to payments UI.

The credit card scanner UI is behind a flag
chrome://flags#scan-card-in-web-payments until UI behavior is polished.

BUG=640430
==========

[please use gerrit instead, 2016-09-09 01:10:19]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-09-09 01:19:06]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-09-09 01:19:07]

dfalcantara, ptal.

The OCR is behind a flag, because the UI is not polished. For example, clicking
anywhere on the text field will launch the credit card scanner. The ideal UI
will use a FrameLayout to place an icon over the text field, but I hope that you
can take care of UI polish after this functionality lands.

[please use gerrit instead, 2016-09-09 01:20:07]

Description was changed from

==========
Add credit card scanner to payments UI.

The credit card scanner UI is behind a flag
chrome://flags#scan-card-in-web-payments until UI behavior is polished.

BUG=640430
==========

to

==========
Add credit card scanner to payments UI.

The credit card scanner UI is behind a flag
chrome://flags#scan-cards-in-web-payments until UI behavior is polished.

BUG=640430
==========

[please use gerrit instead, 2016-09-09 01:20:40]

Description was changed from

==========
Add credit card scanner to payments UI.

The credit card scanner UI is behind a flag
chrome://flags#scan-cards-in-web-payments until UI behavior is polished.

BUG=640430
==========

to

==========
Add credit card scanner to payments UI.

The credit card scanner UI is behind the
chrome://flags#scan-cards-in-web-payments flag until UI behavior is
polished.

BUG=640430
==========

[commit-bot: I haz the power, 2016-09-09 02:34:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 02:34:11]

Dry run: This issue passed the CQ dry run.

[gone, 2016-09-09 17:26:31]

lgtm

https://codereview.chromium.org/2286563002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
(right):

https://codereview.chromium.org/2286563002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java:40:
public static final String WEB_PAYMENTS = "WebPayments";
Could you do me a solid and move WEB_PAYEMNTS into alphabetical order?  It hurts
my sensibilities.

https://codereview.chromium.org/2286563002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
(right):

https://codereview.chromium.org/2286563002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java:123:
public void rereadModel() {
reread is kind of weird.  Can you just call update() or updateModel()?

https://codereview.chromium.org/2286563002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
(right):

https://codereview.chromium.org/2286563002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:250:
assert mInputTypeHint >= INPUT_TYPE_HINT_MIN_INCLUSIVE;
Does this really need to be asserted each time?  Can it just be checked when
mInputTypeHint is set?

[please use gerrit instead, 2016-09-09 17:51:19]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 17:51:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-09-09 17:53:08]

rouslan@chromium.org changed reviewers:
+ estade@chromium.org, holte@chromium.org

[please use gerrit instead, 2016-09-09 17:53:09]

Evan, owner ptal autofill_strings.grdp.

Steven, owner ptal histograms.xml.

https://codereview.chromium.org/2286563002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
(right):

https://codereview.chromium.org/2286563002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java:40:
public static final String WEB_PAYMENTS = "WebPayments";
On 2016/09/09 17:26:30, dfalcantara wrote:
> Could you do me a solid and move WEB_PAYEMNTS into alphabetical order?  It
hurts
> my sensibilities.

Done.

https://codereview.chromium.org/2286563002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
(right):

https://codereview.chromium.org/2286563002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java:123:
public void rereadModel() {
On 2016/09/09 17:26:30, dfalcantara wrote:
> reread is kind of weird.  Can you just call update() or updateModel()?

Done.

https://codereview.chromium.org/2286563002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
(right):

https://codereview.chromium.org/2286563002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:250:
assert mInputTypeHint >= INPUT_TYPE_HINT_MIN_INCLUSIVE;
On 2016/09/09 17:26:30, dfalcantara wrote:
> Does this really need to be asserted each time?  Can it just be checked when
> mInputTypeHint is set?

This is indeed jarring to the eye, but useful to avoid calling
getActionIconResourceId() on a checkbox, for example. As a compromise, I've
moved the code into a helper function, so now I can type "assert isTextField();"
instead. I hope you agree that this looks better.

[please use gerrit instead, 2016-09-09 18:57:06]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 18:57:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Steven Holte, 2016-09-09 20:18:54]

histograms.xml lgtm

[commit-bot: I haz the power, 2016-09-09 20:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 20:29:38]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-09-09 20:40:34]

rs lgtm

[please use gerrit instead, 2016-09-09 20:57:22]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-09-09 20:57:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2286563002/#ps60001
(title: "Rename flag to match histograms.xml")

[commit-bot: I haz the power, 2016-09-09 20:58:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 21:07:16]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-09 21:10:24]

Description was changed from

==========
Add credit card scanner to payments UI.

The credit card scanner UI is behind the
chrome://flags#scan-cards-in-web-payments flag until UI behavior is
polished.

BUG=640430
==========

to

==========
Add credit card scanner to payments UI.

The credit card scanner UI is behind the
chrome://flags#scan-cards-in-web-payments flag until UI behavior is
polished.

BUG=640430

Committed: https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8
Cr-Commit-Position: refs/heads/master@{#417709}
==========

[commit-bot: I haz the power, 2016-09-09 21:10:25]

Patchset 3 (id:??) landed as
https://crrev.com/2cd2a4761a56c717f297184c3b6c65a2ee9e03c8
Cr-Commit-Position: refs/heads/master@{#417709}