third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js - Issue 2286553002: DevTools security panel: explain subresources with cert errors separately

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

Issue 2286553002: DevTools security panel: explain subresources with cert errors separately (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: try to make comment more clear Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

index 77d1a4dc3f36fcbc2f0c1bd06afee0a60462f113..46fb344c36f0203ec305534884a9f75467204677 100644

--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

@@ -73,13 +73,13 @@ WebInspector.SecurityModel.SecurityStateComparator = function(a, b)

* @constructor

* @param {!SecurityAgent.SecurityState} securityState

* @param {!Array<!SecurityAgent.SecurityStateExplanation>} explanations

- * @param {?SecurityAgent.MixedContentStatus} mixedContentStatus

+ * @param {?SecurityAgent.InsecureContentStatus} insecureContentStatus

* @param {boolean} schemeIsCryptographic

-WebInspector.PageSecurityState = function(securityState, explanations, mixedContentStatus, schemeIsCryptographic) {

+WebInspector.PageSecurityState = function(securityState, explanations, insecureContentStatus, schemeIsCryptographic) {

this.securityState = securityState;

this.explanations = explanations;

- this.mixedContentStatus = mixedContentStatus;

+ this.insecureContentStatus = insecureContentStatus;

this.schemeIsCryptographic = schemeIsCryptographic;

}

@@ -97,12 +97,12 @@ WebInspector.SecurityDispatcher.prototype = {

* @override

* @param {!SecurityAgent.SecurityState} securityState

* @param {!Array<!SecurityAgent.SecurityStateExplanation>=} explanations

- * @param {!SecurityAgent.MixedContentStatus=} mixedContentStatus

+ * @param {!SecurityAgent.InsecureContentStatus=} insecureContentStatus

* @param {boolean=} schemeIsCryptographic

- securityStateChanged: function(securityState, explanations, mixedContentStatus, schemeIsCryptographic)

+ securityStateChanged: function(securityState, explanations, insecureContentStatus, schemeIsCryptographic)

{

- var pageSecurityState = new WebInspector.PageSecurityState(securityState, explanations || [], mixedContentStatus || null, schemeIsCryptographic || false);

+ var pageSecurityState = new WebInspector.PageSecurityState(securityState, explanations || [], insecureContentStatus || null, schemeIsCryptographic || false);

this._model.dispatchEventToListeners(WebInspector.SecurityModel.Events.SecurityStateChanged, pageSecurityState);

}