third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html - Issue 2286553002: DevTools security panel: explain subresources with cert errors separately

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

Issue 2286553002: DevTools security panel: explain subresources with cert errors separately (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: try to make comment more clear Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/security/security-blocked-mixed-content.html ('k') | third_party/WebKit/Source/core/inspector/browser_protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html b/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

index 6f085afe8f10ceab8df294c9f5c9708de254c1cb..4848ae2bc7893bf7380450ddf75df7ec4e656c6d 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

@@ -5,7 +5,8 @@

function test()

{

- var mixedContentStatus = { ranInsecureContent: false, displayedInsecureContent: false};

+ /** @type {!SecurityAgent.InsecureContentStatus} */

+ var insecureContentStatus = { ranMixedContent: false, displayedMixedContent: false, ranContentWithCertErrors: false, displayedContentWithCertErrors: false, ranInsecureContentStyle: SecurityAgent.SecurityState.Insecure, displayedInsecureContentStyle: SecurityAgent.SecurityState.Neutral };

// Explanations from https://cbc.badssl.com/ as of 2016-06-13.

// We explicitly place the explanation with the security state "info"

@@ -30,7 +31,7 @@ function test()

}

];

- InspectorTest.mainTarget.model(WebInspector.SecurityModel).dispatchEventToListeners(WebInspector.SecurityModel.Events.SecurityStateChanged, new WebInspector.PageSecurityState(SecurityAgent.SecurityState.Secure, explanations, mixedContentStatus, true));

+ InspectorTest.mainTarget.model(WebInspector.SecurityModel).dispatchEventToListeners(WebInspector.SecurityModel.Events.SecurityStateChanged, new WebInspector.PageSecurityState(SecurityAgent.SecurityState.Secure, explanations, insecureContentStatus, true));

var request = new WebInspector.NetworkRequest(InspectorTest.mainTarget, 0, "http://foo.test", "https://foo.test", 0, 0, null);

InspectorTest.dispatchRequestFinished(request);