Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/security/blocked-mixed-content-and-subresources-with-cert-errors.html

Issue 2286553002: DevTools security panel: explain subresources with cert errors separately (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: try to make comment more clear Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/security/blocked-mixed-content-and-subresources-with-cert-errors.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure.html b/third_party/WebKit/LayoutTests/http/tests/inspector/security/blocked-mixed-content-and-subresources-with-cert-errors.html
similarity index 57%
copy from third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure.html
copy to third_party/WebKit/LayoutTests/http/tests/inspector/security/blocked-mixed-content-and-subresources-with-cert-errors.html
index 9da6be0af577ee468e1cf7d878556462b4ab4657..11d9ac814e0f2321fab8a9c0d8bf064023b736a4 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/security/blocked-mixed-content-and-subresources-with-cert-errors.html
@@ -5,21 +5,24 @@
<script>
function test()
{
- var mixedContentStatus = { ranInsecureContent: false, displayedInsecureContent: false};
-
- InspectorTest.mainTarget.model(WebInspector.SecurityModel).dispatchEventToListeners(WebInspector.SecurityModel.Events.SecurityStateChanged, new WebInspector.PageSecurityState(SecurityAgent.SecurityState.Secure, [], mixedContentStatus, true));
+ /** @type {!SecurityAgent.InsecureContentStatus} */
+ var insecureContentStatus = { ranMixedContent: false, displayedMixedContent: false, ranContentWithCertErrors: false, displayedContentWithCertErrors: true, ranInsecureContentStyle: SecurityAgent.SecurityState.Insecure, displayedInsecureContentStyle: SecurityAgent.SecurityState.Neutral };
+ InspectorTest.mainTarget.model(WebInspector.SecurityModel).dispatchEventToListeners(WebInspector.SecurityModel.Events.SecurityStateChanged, new WebInspector.PageSecurityState(SecurityAgent.SecurityState.Secure, [], insecureContentStatus, true));
var request = new WebInspector.NetworkRequest(InspectorTest.mainTarget, 0, "http://foo.test", "https://foo.test", 0, 0, null);
+ request.setBlockedReason(NetworkAgent.BlockedReason.MixedContent);
+ request.mixedContentType = "blockable";
InspectorTest.dispatchRequestFinished(request);
var explanations = WebInspector.SecurityPanel._instance()._mainView.contentElement.getElementsByClassName("security-explanation");
for (var i = 0; i < explanations.length; i++)
InspectorTest.dumpDeepInnerHTML(explanations[i]);
+
InspectorTest.completeTest();
}
</script>
</head>
<body onload="runTest()">
-<p>Tests addition of explanation when all page resources are transferred securely (no-mixed-content).</p>
+<p>Tests active mixed content blocking in the security panel, along with subresources with cert errors.</p>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698