third_party/WebKit/LayoutTests/http/tests/inspector/security/active-and-passive-subresources-with-cert-errors.html - Issue 2286553002: DevTools security panel: explain subresources with cert errors separately

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/security/active-and-passive-subresources-with-cert-errors.html

Issue 2286553002: DevTools security panel: explain subresources with cert errors separately (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: try to make comment more clear Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/browser/security_style_explanations.cc ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/security/active-and-passive-subresources-with-cert-errors-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/security/active-and-passive-subresources-with-cert-errors.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure.html b/third_party/WebKit/LayoutTests/http/tests/inspector/security/active-and-passive-subresources-with-cert-errors.html

similarity index 62%

copy from third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure.html

copy to third_party/WebKit/LayoutTests/http/tests/inspector/security/active-and-passive-subresources-with-cert-errors.html

index 9da6be0af577ee468e1cf7d878556462b4ab4657..b7445186e1bac62284657672ae7d297b73d39d53 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/security/active-and-passive-subresources-with-cert-errors.html

@@ -5,9 +5,10 @@

function test()

{

- var mixedContentStatus = { ranInsecureContent: false, displayedInsecureContent: false};

+ /** @type {!SecurityAgent.InsecureContentStatus} */

+ var insecureContentStatus = { ranMixedContent: false, displayedMixedContent: false, ranContentWithCertErrors: true, displayedContentWithCertErrors: true, ranInsecureContentStyle: SecurityAgent.SecurityState.Insecure, displayedInsecureContentStyle: SecurityAgent.SecurityState.Neutral };

- InspectorTest.mainTarget.model(WebInspector.SecurityModel).dispatchEventToListeners(WebInspector.SecurityModel.Events.SecurityStateChanged, new WebInspector.PageSecurityState(SecurityAgent.SecurityState.Secure, [], mixedContentStatus, true));

+ InspectorTest.mainTarget.model(WebInspector.SecurityModel).dispatchEventToListeners(WebInspector.SecurityModel.Events.SecurityStateChanged, new WebInspector.PageSecurityState(SecurityAgent.SecurityState.Insecure, [], insecureContentStatus, true));

var request = new WebInspector.NetworkRequest(InspectorTest.mainTarget, 0, "http://foo.test", "https://foo.test", 0, 0, null);

InspectorTest.dispatchRequestFinished(request);

@@ -20,6 +21,6 @@ function test()

</script>

</head>

-<p>Tests addition of explanation when all page resources are transferred securely (no-mixed-content).</p>

+<p>Tests addition of explanation when active and passive subresources were loaded with certificate errors.</p>

</body>

</html>