Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: content/browser/devtools/protocol/security_handler.cc

Issue 2286553002: DevTools security panel: explain subresources with cert errors separately (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: try to make comment more clear Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | content/public/browser/security_style_explanations.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/security_handler.cc
diff --git a/content/browser/devtools/protocol/security_handler.cc b/content/browser/devtools/protocol/security_handler.cc
index 4a2bce8ea2d79fb3e3c40a468023c321613c6832..8242203d94a88b4308d1e6eb3bb3eec17d76ddf7 100644
--- a/content/browser/devtools/protocol/security_handler.cc
+++ b/content/browser/devtools/protocol/security_handler.cc
@@ -108,12 +108,15 @@ void SecurityHandler::SecurityStyleChanged(
AddExplanations(kSecurityStateInfo,
security_style_explanations.info_explanations, &explanations);
- scoped_refptr<MixedContentStatus> mixed_content_status =
- MixedContentStatus::Create()
- ->set_ran_insecure_content(
- security_style_explanations.ran_insecure_content)
- ->set_displayed_insecure_content(
- security_style_explanations.displayed_insecure_content)
+ scoped_refptr<InsecureContentStatus> insecure_content_status =
+ InsecureContentStatus::Create()
+ ->set_ran_mixed_content(security_style_explanations.ran_mixed_content)
+ ->set_displayed_mixed_content(
+ security_style_explanations.displayed_mixed_content)
+ ->set_ran_content_with_cert_errors(
+ security_style_explanations.ran_content_with_cert_errors)
+ ->set_displayed_content_with_cert_errors(
+ security_style_explanations.displayed_content_with_cert_errors)
->set_ran_insecure_content_style(SecurityStyleToProtocolSecurityState(
security_style_explanations.ran_insecure_content_style))
->set_displayed_insecure_content_style(
@@ -126,7 +129,7 @@ void SecurityHandler::SecurityStyleChanged(
->set_security_state(security_state)
->set_scheme_is_cryptographic(
security_style_explanations.scheme_is_cryptographic)
- ->set_mixed_content_status(mixed_content_status)
+ ->set_insecure_content_status(insecure_content_status)
->set_explanations(explanations));
}
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | content/public/browser/security_style_explanations.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698