Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Unified Diff: content/public/browser/security_style_explanations.h

Issue 2286553002: DevTools security panel: explain subresources with cert errors separately (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: some missed renames Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/security_style_explanations.h
diff --git a/content/public/browser/security_style_explanations.h b/content/public/browser/security_style_explanations.h
index 3b8a28d53cab0b6c08f160fe374c1a8f98aab7a8..e08e0446ef81eace5bf9ace0d1cfdfc0a19ecd88 100644
--- a/content/public/browser/security_style_explanations.h
+++ b/content/public/browser/security_style_explanations.h
@@ -29,14 +29,28 @@ struct SecurityStyleExplanations {
CONTENT_EXPORT SecurityStyleExplanations();
CONTENT_EXPORT ~SecurityStyleExplanations();
- // True if the page ran insecure content such as scripts.
- bool ran_insecure_content;
- // True if the page displayed insecure content such as images.
- bool displayed_insecure_content;
+ // True if the page was loaded over HTTPS and ran mixed (HTTP) content
+ // such as scripts.
+ bool ran_mixed_content;
+ // True if the page was loaded over HTTPS and displayed mixed (HTTP)
+ // content such as images.
+ bool displayed_mixed_content;
+ // True if the page was loaded over HTTPS without certificate errors,
+ // but ran subresources, such as scripts, that were loaded over HTTPS
+ // with certificate errors.
+ bool ran_content_with_cert_errors;
+ // True if the page was loaded over HTTPS without certificate errors,
+ // but displayed subresources, such as images, that were loaded over HTTPS
+ // with certificate errors.
+ bool displayed_content_with_cert_errors;
// The SecurityStyle assigned to a page that runs or displays insecure
- // content, respectively. These values are used to convey the effect
- // that mixed content has on the overall SecurityStyle of the page;
+ // content, respectively. Insecure content can be either HTTP
+ // subresources loaded on an HTTPS page (mixed content), or HTTPS
+ // subresources loaded with certificate errors on an HTTPS page.
+ //
+ // These values are used to convey the effect
+ // that insecure content has on the overall SecurityStyle of the page;
// for example, a |displayed_insecure_content_style| value of
// SECURITY_STYLE_UNAUTHENTICATED indicates that the page's overall
// SecurityStyle will be downgraded to UNAUTHENTICATED as a result of

Powered by Google App Engine
This is Rietveld 408576698