third_party/WebKit/LayoutTests/http/tests/inspector/security/mixed-content-and-subresources-with-cert-errors.html - Issue 2286553002: DevTools security panel: explain subresources with cert errors separately

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/inspector/security/mixed-content-and-subresources-with-cert-errors.html

Issue 2286553002: DevTools security panel: explain subresources with cert errors separately (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: try to make comment more clear Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/security/blocked-mixed-content-and-subresources-with-cert-errors-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/security/mixed-content-and-subresources-with-cert-errors-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../inspector-test.js"></script>	3 <script src="../inspector-test.js"></script>

4 <script src="../security-test.js"></script>	4 <script src="../security-test.js"></script>

5 <script>	5 <script>

6 function test()	6 function test()

7 {	7 {

8 var mixedContentStatus = { ranInsecureContent: false, displayedInsecureConte nt: false};	8 /** @type {!SecurityAgent.InsecureContentStatus} */

	9 var insecureContentStatus = { ranMixedContent: true, displayedMixedContent: true, ranContentWithCertErrors: true, displayedContentWithCertErrors: true, ranI nsecureContentStyle: SecurityAgent.SecurityState.Insecure, displayedInsecureCont entStyle: SecurityAgent.SecurityState.Neutral };

9	10

10 InspectorTest.mainTarget.model(WebInspector.SecurityModel).dispatchEventToLi steners(WebInspector.SecurityModel.Events.SecurityStateChanged, new WebInspector .PageSecurityState(SecurityAgent.SecurityState.Secure, [], mixedContentStatus, t rue));	11 InspectorTest.mainTarget.model(WebInspector.SecurityModel).dispatchEventToLi steners(WebInspector.SecurityModel.Events.SecurityStateChanged, new WebInspector .PageSecurityState(SecurityAgent.SecurityState.Insecure, [], insecureContentStat us, true));

11	12

12 var request = new WebInspector.NetworkRequest(InspectorTest.mainTarget, 0, " http://foo.test", "https://foo.test", 0, 0, null);	13 var request = new WebInspector.NetworkRequest(InspectorTest.mainTarget, 0, " http://foo.test", "https://foo.test", 0, 0, null);

13 InspectorTest.dispatchRequestFinished(request);	14 InspectorTest.dispatchRequestFinished(request);

14	15

15 var explanations = WebInspector.SecurityPanel._instance()._mainView.contentE lement.getElementsByClassName("security-explanation");	16 var explanations = WebInspector.SecurityPanel._instance()._mainView.contentE lement.getElementsByClassName("security-explanation");

16 for (var i = 0; i < explanations.length; i++)	17 for (var i = 0; i < explanations.length; i++)

17 InspectorTest.dumpDeepInnerHTML(explanations[i]);	18 InspectorTest.dumpDeepInnerHTML(explanations[i]);

18 InspectorTest.completeTest();	19 InspectorTest.completeTest();

19 }	20 }

20 </script>	21 </script>

21 </head>	22 </head>

22 <body onload="runTest()">	23 <body onload="runTest()">

23 <p>Tests addition of explanation when all page resources are transferred securel y (no-mixed-content).</p>	24 <p>Tests addition of explanation when there was both mixed content and subresour ces were loaded with certificate errors.</p>

24 </body>	25 </body>

25 </html>	26 </html>

OLD	NEW