third_party/WebKit/Source/core/svg/SVGLengthContext.cpp - Issue 2286543002: Add Length::isPercent and use it in tables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLengthContext.cpp

Issue 2286543002: Add Length::isPercent and use it in tables. (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGLengthContext.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp b/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp

index 5b265e1b6e7cc5a959b1d373185a5dda1179426d..7b33d95a029b09437e1ecba752fd4e2fc53c4e4f 100644

--- a/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp

@@ -211,7 +211,7 @@ float SVGLengthContext::valueForLength(const Length& length, const ComputedStyle

float SVGLengthContext::valueForLength(const Length& length, float zoom, SVGLengthMode mode) const

{

float dimension = 0;

- if (length.hasPercent()) {

+ if (length.isPercentOrCalc()) {

FloatSize viewportSize;

determineViewport(viewportSize);

// The viewport will be unaffected by zoom.