third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc - Issue 2286543002: Add Length::isPercent and use it in tables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

Issue 2286543002: Add Length::isPercent and use it in tables. (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

index 10b9102d797bb0a73e69da7ab4577a0cb45d9393..f01a9e9353c377e4ddb5b572c52ba2769d9ac944 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

@@ -50,7 +50,7 @@ LayoutUnit resolveBlockLength(const NGConstraintSpace& constraintSpace,

// Make sure that indefinite percentages resolve to NGSizeIndefinite, not to

// a random negative number.

- if (length.hasPercent() &&

+ if (length.isPercentOrCalc() &&

constraintSpace.ContainerSize().block_size == NGSizeIndefinite)

return contentSize;