third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp - Issue 2286543002: Add Length::isPercent and use it in tables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

Issue 2286543002: Add Length::isPercent and use it in tables. (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTextControl.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp b/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

index 0366fe8aa3de72cd44c0bcc5ee5c14a5faec2b3d..d762b843cb68937c0613e82a659970c84caeed2e 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

@@ -288,7 +288,7 @@ PassRefPtr<ComputedStyle> LayoutTextControlSingleLine::createInnerEditorStyle(co

// in which we don't want to remove line-height with percent or calculated

// length.

// TODO(tkent): This should be done during layout.

- if (logicalHeight.hasPercent() || (logicalHeight.isFixed() && logicalHeight.getFloatValue() > computedLineHeight))

+ if (logicalHeight.isPercentOrCalc() || (logicalHeight.isFixed() && logicalHeight.getFloatValue() > computedLineHeight))

textBlockStyle->setLineHeight(ComputedStyle::initialLineHeight());

textBlockStyle->setDisplay(BLOCK);