third_party/WebKit/Source/core/layout/LayoutTable.cpp - Issue 2286543002: Add Length::isPercent and use it in tables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTable.cpp

Issue 2286543002: Add Length::isPercent and use it in tables. (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTable.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.cpp b/third_party/WebKit/Source/core/layout/LayoutTable.cpp

index fcdb4dfdcb35035ef0c850e9ca39327eff509f05..24012785ab7202fb72a7c57e078ce350cf801243 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTable.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTable.cpp

@@ -352,7 +352,7 @@ LayoutUnit LayoutTable::convertStyleLogicalHeightToComputedHeight(const Length&

borders = borderAndPadding;

}

computedLogicalHeight = LayoutUnit(styleLogicalHeight.value() - borders);

- } else if (styleLogicalHeight.hasPercent()) {

+ } else if (styleLogicalHeight.isPercentOrCalc()) {

computedLogicalHeight = computePercentageLogicalHeight(styleLogicalHeight);

} else if (styleLogicalHeight.isIntrinsic()) {

computedLogicalHeight = computeIntrinsicLogicalContentHeightUsing(styleLogicalHeight, logicalHeight() - borderAndPadding, borderAndPadding);