third_party/WebKit/Source/core/layout/LayoutImage.cpp - Issue 2286543002: Add Length::isPercent and use it in tables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutImage.cpp

Issue 2286543002: Add Length::isPercent and use it in tables. (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutImage.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutImage.cpp b/third_party/WebKit/Source/core/layout/LayoutImage.cpp

index 41032bd16efc128b49743304bb8253b84473600a..aa8de2252107f47fd45f9309085cfabf328eb119 100644

--- a/third_party/WebKit/Source/core/layout/LayoutImage.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutImage.cpp

@@ -151,7 +151,7 @@ void LayoutImage::invalidatePaintAndMarkForLayoutIfNeeded()

// FIXME: We only need to recompute the containing block's preferred size if the containing block's size

// depends on the image's size (i.e., the container uses shrink-to-fit sizing).

// There's no easy way to detect that shrink-to-fit is needed, always force a layout.

- bool containingBlockNeedsToRecomputePreferredSize = style()->logicalWidth().hasPercent() || style()->logicalMaxWidth().hasPercent() || style()->logicalMinWidth().hasPercent();

+ bool containingBlockNeedsToRecomputePreferredSize = style()->logicalWidth().isPercentOrCalc() || style()->logicalMaxWidth().isPercentOrCalc() || style()->logicalMinWidth().isPercentOrCalc();

if (imageSourceHasChangedSize && (!imageSizeIsConstrained || containingBlockNeedsToRecomputePreferredSize)) {

setNeedsLayoutAndFullPaintInvalidation(LayoutInvalidationReason::SizeChanged);