Add Length::isPercent and use it in tables.

third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp

 /*
  * Copyright (C) 2002 Lars Knoll (knoll@kde.org)
  *           (C) 2002 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License.
  *
@@ skipping 100 matching lines @@
                 spanInCurrentEffectiveColumn = span;
             } else {
                 if (span < m_table->spanOfEffectiveColumn(currentEffectiveColumn)) {
                     m_table->splitEffectiveColumn(currentEffectiveColumn, span);
                     nEffCols++;
                     m_width.append(Length());
                 }
                 spanInCurrentEffectiveColumn = m_table->spanOfEffectiveColumn(currentEffectiveColumn);
             }
             // TODO(alancutter): Make this work correctly for calc lengths.
-            if ((colStyleLogicalWidth.isFixed() || colStyleLogicalWidth.hasPercent()) && colStyleLogicalWidth.isPositive()) {
+            if ((colStyleLogicalWidth.isFixed() || colStyleLogicalWidth.isPercentOrCalc()) && colStyleLogicalWidth.isPositive()) {
                 m_width[currentEffectiveColumn] = colStyleLogicalWidth;
                 m_width[currentEffectiveColumn] *= spanInCurrentEffectiveColumn;
                 usedWidth += effectiveColWidth * spanInCurrentEffectiveColumn;
             }
             span -= spanInCurrentEffectiveColumn;
             currentEffectiveColumn++;
         }
     }
 
     // Iterate over the first row in case some are unspecified.
@@ skipping 60 matching lines @@
             <table style="background-color:blue"><tr><td>
                 <table style="width:100%; background-color:green; table-layout:fixed"><tr><td>
                     Content
                 </td></tr></table>
             </td></tr></table>
         </td></tr></table>
     */
     // In this example, the two inner tables should be as large as the outer table.
     // We can achieve this effect by making the maxwidth of fixed tables with percentage
     // widths be infinite.
-    if (m_table->style()->logicalWidth().hasPercent() && maxWidth < tableMaxWidth)
+    if (m_table->style()->logicalWidth().isPercentOrCalc() && maxWidth < tableMaxWidth)
         maxWidth = LayoutUnit(tableMaxWidth);
 }
 
 void TableLayoutAlgorithmFixed::layout()
 {
     int tableLogicalWidth = (m_table->logicalWidth() - m_table->bordersPaddingAndSpacingInRowDirection()).toInt();
     unsigned nEffCols = m_table->numEffectiveColumns();
 
     // FIXME: It is possible to be called without having properly updated our internal representation.
     // This means that our preferred logical widths were not recomputed as expected.
@@ skipping 12 matching lines @@
     float totalPercent = 0;
 
     // Compute requirements and try to satisfy fixed and percent widths.
     // Percentages are of the table's width, so for example
     // for a table width of 100px with columns (40px, 10%), the 10% compute
     // to 10px here, and will scale up to 20px in the final (80px, 20px).
     for (unsigned i = 0; i < nEffCols; i++) {
         if (m_width[i].isFixed()) {
             calcWidth[i] = m_width[i].value();
             totalFixedWidth += calcWidth[i];
-        } else if (m_width[i].hasPercent()) {
+        } else if (m_width[i].isPercentOrCalc()) {
             // TODO(alancutter): Make this work correctly for calc lengths.
             calcWidth[i] = valueForLength(m_width[i], LayoutUnit(tableLogicalWidth)).toInt();
             totalPercentWidth += calcWidth[i];
             totalPercent += m_width[i].percent();
         } else if (m_width[i].isAuto()) {
             numAuto++;
             autoSpan += m_table->spanOfEffectiveColumn(i);
         }
     }
 
@@ skipping 10 matching lines @@
                     if (m_width[i].isFixed()) {
                         calcWidth[i] = calcWidth[i] * tableLogicalWidth / totalWidth;
                         totalFixedWidth += calcWidth[i];
                     }
                 }
             }
             if (totalPercent) {
                 totalPercentWidth = 0;
                 for (unsigned i = 0; i < nEffCols; i++) {
                     // TODO(alancutter): Make this work correctly for calc lengths.
-                    if (m_width[i].hasPercent()) {
+                    if (m_width[i].isPercentOrCalc()) {
                         calcWidth[i] = m_width[i].percent() * (tableLogicalWidth - totalFixedWidth) / totalPercent;
                         totalPercentWidth += calcWidth[i];
                     }
                 }
             }
             totalWidth = totalFixedWidth + totalPercentWidth;
         }
     } else {
         // Divide the remaining width among the auto columns.
         ASSERT(autoSpan >= numAuto);
@@ skipping 47 matching lines @@
     // When switching table layout algorithm, we need to dirty the preferred
     // logical widths as we cleared the bits without computing them.
     // (see calcWidthArray above.) This optimization is preferred to always
     // computing the logical widths we never intended to use.
     m_table->recalcSectionsIfNeeded();
     for (LayoutTableSection* section = m_table->topNonEmptySection(); section; section = m_table->sectionBelow(section))
         section->markAllCellsWidthsDirtyAndOrNeedsLayout(LayoutTableSection::MarkDirtyOnly);
 }
 
 } // namespace blink