Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 228653006: Pepper: Fix comments for PPB and PPP InputEvent. (Closed)

Created:
6 years, 8 months ago by teravest
Modified:
6 years, 8 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, raymes+watch_chromium.org, teravest+watch_chromium.org, yzshen+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, binji, ihf+watch_chromium.org
Visibility:
Public.

Description

Pepper: Fix comments for PPB and PPP InputEvent. The comments provided in PPB_InputEvent and PPP_InputEvent incorrectly describe how handled events are delivered to handlers in web pages. When a plugin handles an event, the event is not "bubbled" to any default handlers. However, any listeners in a web page run before the event reaches the plugin, so the plugin can't prevent any listeners from getting the event. An attempt to make the implementation match the specification broke existing plugins, so the only reasonable approach is to make the comments match the behavior. BUG=324351

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes for dmichael #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M ppapi/api/ppb_input_event.idl View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/api/ppp_input_event.idl View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/c/ppb_input_event.h View 3 chunks +4 lines, -6 lines 0 comments Download
M ppapi/c/ppp_input_event.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/cpp/instance.h View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
teravest
6 years, 8 months ago (2014-04-08 18:30:30 UTC) #1
dmichael (off chromium)
lgtm https://codereview.chromium.org/228653006/diff/1/ppapi/api/ppp_input_event.idl File ppapi/api/ppp_input_event.idl (right): https://codereview.chromium.org/228653006/diff/1/ppapi/api/ppp_input_event.idl#newcode24 ppapi/api/ppp_input_event.idl:24: * in the web page. If it was ...
6 years, 8 months ago (2014-04-08 19:37:59 UTC) #2
teravest
On Tue, Apr 8, 2014 at 1:37 PM, <dmichael@chromium.org> wrote: > lgtm > > > ...
6 years, 8 months ago (2014-04-08 21:21:40 UTC) #3
teravest
6 years, 8 months ago (2014-04-10 19:13:02 UTC) #4
Submitted.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263034

Powered by Google App Engine
This is Rietveld 408576698