Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2286523002: Relocate reuseable portions of ash/display/display_util.* (Closed)

Created:
4 years, 3 months ago by rjkroege
Modified:
4 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relocate reuseable portions of ash/display/display_util.* To permit reuse in mus, relocate the reuseable portions of ash/display/display_util.cc and ash/display/display_util.h into ui. BUG=581462 Committed: https://crrev.com/0458f0194078b4d9dac6c384b62c4248beb9b220 Cr-Commit-Position: refs/heads/master@{#415513}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fixed ozone build #

Total comments: 4

Patch Set 4 : review comments, rebased #

Patch Set 5 : fixed ozone build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -767 lines) Patch
M ash/accelerators/accelerator_commands_aura.cc View 1 2 3 2 chunks +2 lines, -32 lines 0 comments Download
M ash/display/display_change_observer_chromeos.cc View 1 2 3 3 chunks +7 lines, -6 lines 0 comments Download
M ash/display/display_manager.h View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M ash/display/display_manager.cc View 1 2 3 8 chunks +46 lines, -9 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 2 3 3 chunks +4 lines, -11 lines 0 comments Download
M ash/display/display_util.h View 1 2 3 2 chunks +1 line, -84 lines 0 comments Download
M ash/display/display_util.cc View 1 2 3 4 chunks +0 lines, -282 lines 0 comments Download
M ash/display/display_util_unittest.cc View 1 chunk +1 line, -85 lines 0 comments Download
M ash/display/extended_mouse_warp_controller.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M ash/display/unified_mouse_warp_controller.cc View 1 2 3 4 4 chunks +8 lines, -6 lines 0 comments Download
M ash/display/unified_mouse_warp_controller_unittest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M ash/test/display_manager_test_api.cc View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 1 2 3 7 chunks +8 lines, -7 lines 0 comments Download
M ui/display/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/display/manager/display_layout_store.cc View 1 3 1 chunk +1 line, -26 lines 0 comments Download
A ui/display/manager/display_manager_utilities.h View 1 2 3 1 chunk +110 lines, -0 lines 0 comments Download
A + ui/display/manager/display_manager_utilities.cc View 1 2 3 7 chunks +13 lines, -211 lines 0 comments Download
A ui/display/manager/display_manager_utilities_unittest.cc View 1 2 3 1 chunk +122 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
rjkroege
Yet more relocation of display code.
4 years, 3 months ago (2016-08-26 00:17:49 UTC) #2
oshima
lgtm https://codereview.chromium.org/2286523002/diff/40001/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/2286523002/diff/40001/ash/display/display_manager.cc#newcode1115 ash/display/display_manager.cc:1115: return SetDisplayMode(display_id, mode); nit: return mode ? SetDisplayMode() ...
4 years, 3 months ago (2016-08-26 21:55:59 UTC) #3
rjkroege
https://codereview.chromium.org/2286523002/diff/40001/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/2286523002/diff/40001/ash/display/display_manager.cc#newcode1115 ash/display/display_manager.cc:1115: return SetDisplayMode(display_id, mode); On 2016/08/26 21:55:59, oshima wrote: > ...
4 years, 3 months ago (2016-08-30 19:11:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286523002/60001
4 years, 3 months ago (2016-08-30 22:44:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286523002/80001
4 years, 3 months ago (2016-08-30 23:23:03 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-31 00:31:56 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 00:33:42 UTC) #14
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/0458f0194078b4d9dac6c384b62c4248beb9b220
Cr-Commit-Position: refs/heads/master@{#415513}

Powered by Google App Engine
This is Rietveld 408576698