Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: test/cctest/test-code-stubs-ia32.cc

Issue 22865006: Fix bug in test-code-stubs-x64 which meant not all registers were being checked. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-code-stubs-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-code-stubs-ia32.cc
diff --git a/test/cctest/test-code-stubs-ia32.cc b/test/cctest/test-code-stubs-ia32.cc
index a3c0b54e259e9c1f5547a051937e7858725c3283..3f621758e3c0e5f9c0955cd1f15deaf2c21eb94d 100644
--- a/test/cctest/test-code-stubs-ia32.cc
+++ b/test/cctest/test-code-stubs-ia32.cc
@@ -136,46 +136,15 @@ TEST(ConvertDToI) {
RunAllTruncationTests(&ConvertDToICVersion);
#endif
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, esp, eax));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, esp, ebx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, esp, ecx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, esp, edx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, esp, edi));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, esp, esi));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, eax, eax));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, eax, ebx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, eax, ecx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, eax, edx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, eax, edi));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, eax, esi));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, ebx, eax));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, ebx, ebx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, ebx, ecx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, ebx, edx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, ebx, edi));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, ebx, esi));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, ecx, eax));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, ecx, ebx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, ecx, ecx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, ecx, edx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, ecx, edi));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, ecx, esi));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, edx, eax));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, edx, ebx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, edx, ecx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, edx, edx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, edx, edi));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, edx, esi));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, esi, eax));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, esi, ebx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, esi, ecx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, esi, edx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, esi, edi));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, esi, esi));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, edi, eax));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, edi, ebx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, edi, ecx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, edi, edx));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, edi, edi));
- RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, edi, esi));
+ Register source_registers[] = {esp, eax, ebx, ecx, edx, edi, esi};
+ Register dest_registers[] = {eax, ebx, ecx, edx, edi, esi};
+
+ for (size_t s = 0; s < sizeof(source_registers) / sizeof(Register); s++) {
+ for (size_t d = 0; d < sizeof(dest_registers) / sizeof(Register); d++) {
+ RunAllTruncationTests(
+ MakeConvertDToIFuncTrampoline(isolate,
+ source_registers[s],
+ dest_registers[d]));
+ }
+ }
}
« no previous file with comments | « no previous file | test/cctest/test-code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698