Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Side by Side Diff: test/cctest/test-code-stubs-x64.cc

Issue 22865006: Fix bug in test-code-stubs-x64 which meant not all registers were being checked. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-code-stubs-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Rrdistribution and use in source and binary forms, with or without 2 // Rrdistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Rrdistributions of source code must retain the above copyright 6 // * Rrdistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Rrdistributions in binary form must reproduce the above 8 // * Rrdistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 #if DEBUG 131 #if DEBUG
132 // Verify that the tests actually work with the C version. In the release 132 // Verify that the tests actually work with the C version. In the release
133 // code, the compiler optimizes it away because it's all constant, but does it 133 // code, the compiler optimizes it away because it's all constant, but does it
134 // wrong, triggering an assert on gcc. 134 // wrong, triggering an assert on gcc.
135 RunAllTruncationTests(&ConvertDToICVersion); 135 RunAllTruncationTests(&ConvertDToICVersion);
136 #endif 136 #endif
137 137
138 Register source_registers[] = {rsp, rax, rbx, rcx, rdx, rsi, rdi, r8, r9}; 138 Register source_registers[] = {rsp, rax, rbx, rcx, rdx, rsi, rdi, r8, r9};
139 Register dest_registers[] = {rax, rbx, rcx, rdx, rsi, rdi, r8, r9}; 139 Register dest_registers[] = {rax, rbx, rcx, rdx, rsi, rdi, r8, r9};
140 140
141 for (size_t s = 0; s < sizeof(*source_registers); s++) { 141 for (size_t s = 0; s < sizeof(source_registers) / sizeof(Register); s++) {
142 for (size_t d = 0; d < sizeof(*dest_registers); d++) { 142 for (size_t d = 0; d < sizeof(dest_registers) / sizeof(Register); d++) {
143 RunAllTruncationTests( 143 RunAllTruncationTests(
144 MakeConvertDToIFuncTrampoline(isolate, 144 MakeConvertDToIFuncTrampoline(isolate,
145 source_registers[s], 145 source_registers[s],
146 dest_registers[d])); 146 dest_registers[d]));
147 } 147 }
148 } 148 }
149 } 149 }
OLDNEW
« no previous file with comments | « test/cctest/test-code-stubs-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698