Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 22865006: Fix bug in test-code-stubs-x64 which meant not all registers were being checked. (Closed)

Created:
7 years, 4 months ago by rmcilroy
Modified:
7 years, 4 months ago
Reviewers:
danno
Visibility:
Public.

Description

Fix bug in test-code-stubs-x64 which meant not all registers were being checked. Also change test-code-stubs-ia32 to use the same style as x64. BUG= R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -44 lines) Patch
M test/cctest/test-code-stubs-ia32.cc View 1 chunk +11 lines, -42 lines 0 comments Download
M test/cctest/test-code-stubs-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmcilroy
Noticed this when writing a similar test for arm.
7 years, 4 months ago (2013-08-13 10:43:29 UTC) #1
danno
lgtm
7 years, 4 months ago (2013-08-13 10:49:19 UTC) #2
rmcilroy
On 2013/08/13 10:49:19, danno wrote: > lgtm Is the tree open again? If so, could ...
7 years, 4 months ago (2013-08-16 09:43:39 UTC) #3
danno
7 years, 4 months ago (2013-08-16 11:30:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16203.

Powered by Google App Engine
This is Rietveld 408576698