Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2286493002: cc: Fix pixeltest expectations for the waterfall. (Closed)

Created:
4 years, 3 months ago by danakj
Modified:
4 years, 3 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix pixeltest expectations for the waterfall. The waterfall bots have different pixel output from skia scaling than trybots or local results. Make the fuzzy expectations work for the waterfall. TBR=enne BUG=606056, 641056 NOTRY=true Committed: https://crrev.com/dbf30e19b59f63adc8fd0dafd2e245218bc8d798 Cr-Commit-Position: refs/heads/master@{#414569}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/trees/layer_tree_host_pixeltest_scrollbars.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
danakj
4 years, 3 months ago (2016-08-25 22:45:05 UTC) #2
danakj
The numbers match what we get here: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/27346/steps/cc_unittests%20on%20Mac-10.9/logs/LayerTreeHostScrollbarsPixelTest.HugeTransformScale https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/45399/steps/cc_unittests%20on%20Ubuntu-12.04/logs/LayerTreeHostScrollbarsPixelTest.HugeTransformScale
4 years, 3 months ago (2016-08-25 22:46:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286493002/1
4 years, 3 months ago (2016-08-25 22:46:10 UTC) #6
danakj
And windows: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/56592/steps/cc_unittests%20on%20Windows-7-SP1/logs/LayerTreeHostScrollbarsPixelTest.HugeTransformScale
4 years, 3 months ago (2016-08-25 22:46:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286493002/1
4 years, 3 months ago (2016-08-25 22:47:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 22:51:24 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 22:52:58 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbf30e19b59f63adc8fd0dafd2e245218bc8d798
Cr-Commit-Position: refs/heads/master@{#414569}

Powered by Google App Engine
This is Rietveld 408576698