Serialize Google Update state as part of the recovery component update checks.

Serialize Google Update state as part of the recovery component update checks.

TBR=waffles
BUG=615187
Committed: https://crrev.com/eae115a524fb7300c00b03ee3cc81486833e12ce
Cr-Commit-Position: refs/heads/master@{#414632}

[Sorin Jianu, 2016-08-25 22:39:40]

Description was changed from

==========
Serialize Google Update state as part of the recovery component update checks.

BUG=615187
==========

to

==========
Serialize Google Update state as part of the recovery component update checks.

TBR=waffles
BUG=615187
==========

[Sorin Jianu, 2016-08-25 22:39:40]

sorin@chromium.org changed reviewers:
+ waffles@chromium.org

[Sorin Jianu, 2016-08-25 22:39:47]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2016-08-25 22:40:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[waffles, 2016-08-25 23:17:55]

lgtm

https://codereview.chromium.org/2286483002/diff/1/components/component_update...
File components/component_updater/updater_state_win.cc (right):

https://codereview.chromium.org/2286483002/diff/1/components/component_update...
components/component_updater/updater_state_win.cc:100: val = "1440";  // 2
months in hours.
Maybe stick with 28-day long "months"? (1344)

https://codereview.chromium.org/2286483002/diff/1/components/component_update...
components/component_updater/updater_state_win.cc:155: (value == 0 || value >
kCheckPeriodOverrideMinutesMax)) {
Is it possible for value < 0? If so, what happens in this case?

[Sorin Jianu, 2016-08-25 23:20:47]

https://codereview.chromium.org/2286483002/diff/1/components/component_update...
File components/component_updater/updater_state_win.cc (right):

https://codereview.chromium.org/2286483002/diff/1/components/component_update...
components/component_updater/updater_state_win.cc:100: val = "1440";  // 2
months in hours.
On 2016/08/25 23:17:55, waffles wrote:
> Maybe stick with 28-day long "months"? (1344)

Done.

https://codereview.chromium.org/2286483002/diff/1/components/component_update...
components/component_updater/updater_state_win.cc:155: (value == 0 || value >
kCheckPeriodOverrideMinutesMax)) {
On 2016/08/25 23:17:55, waffles wrote:
> Is it possible for value < 0? If so, what happens in this case?

it is an unsigned type.

[Sorin Jianu, 2016-08-25 23:27:51]

The CQ bit was checked by sorin@chromium.org

[Sorin Jianu, 2016-08-25 23:27:51]

The patchset sent to the CQ was uploaded after l-g-t-m from waffles@chromium.org
Link to the patchset: https://codereview.chromium.org/2286483002/#ps40001
(title: "up to #6")

[commit-bot: I haz the power, 2016-08-25 23:28:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sorin Jianu, 2016-08-25 23:47:52]

The CQ bit was checked by sorin@chromium.org

[Sorin Jianu, 2016-08-25 23:47:52]

The patchset sent to the CQ was uploaded after l-g-t-m from waffles@chromium.org
Link to the patchset: https://codereview.chromium.org/2286483002/#ps60001
(title: "remove unused")

[commit-bot: I haz the power, 2016-08-25 23:48:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 02:27:37]

Description was changed from

==========
Serialize Google Update state as part of the recovery component update checks.

TBR=waffles
BUG=615187
==========

to

==========
Serialize Google Update state as part of the recovery component update checks.

TBR=waffles
BUG=615187
==========

[commit-bot: I haz the power, 2016-08-26 02:27:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-26 02:30:40]

Description was changed from

==========
Serialize Google Update state as part of the recovery component update checks.

TBR=waffles
BUG=615187
==========

to

==========
Serialize Google Update state as part of the recovery component update checks.

TBR=waffles
BUG=615187

Committed: https://crrev.com/eae115a524fb7300c00b03ee3cc81486833e12ce
Cr-Commit-Position: refs/heads/master@{#414632}
==========

[commit-bot: I haz the power, 2016-08-26 02:30:42]

Patchset 4 (id:??) landed as
https://crrev.com/eae115a524fb7300c00b03ee3cc81486833e12ce
Cr-Commit-Position: refs/heads/master@{#414632}