Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 228643004: device/bluetooth: Add chromeos::BluetoothRemoteGattCharacteristicChromeOS. (Closed)

Created:
6 years, 8 months ago by armansito
Modified:
6 years, 8 months ago
Reviewers:
keybuk
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

device/bluetooth: Add chromeos::BluetoothRemoteGattCharacteristicChromeOS. Added the chromeos::BluetoothRemoteGattCharacteristicChromeOS class which implements a remote instance of device::BluetoothGattCharacteristic for the Chrome OS platform. BUG=360266, 340529 TEST=device_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262964

Patch Set 1 #

Patch Set 2 : Removed potentially flaky expectation from unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1014 lines, -74 lines) Patch
M chromeos/dbus/fake_bluetooth_gatt_characteristic_client.h View 2 chunks +10 lines, -4 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_characteristic_client.cc View 3 chunks +21 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_service_client.h View 4 chunks +20 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_service_client.cc View 6 chunks +40 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_characteristic.h View 7 chunks +26 lines, -9 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 1 14 chunks +380 lines, -10 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_descriptor.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_gatt_service.h View 3 chunks +54 lines, -13 lines 0 comments Download
A device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.h View 1 chunk +93 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc View 1 chunk +181 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.h View 4 chunks +29 lines, -12 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.cc View 4 chunks +150 lines, -14 lines 0 comments Download
M device/bluetooth/bluetooth_uuid.h View 1 chunk +3 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_uuid.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
armansito
6 years, 8 months ago (2014-04-08 14:56:02 UTC) #1
keybuk
lgtm
6 years, 8 months ago (2014-04-09 22:14:51 UTC) #2
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 8 months ago (2014-04-10 03:07:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/228643004/20001
6 years, 8 months ago (2014-04-10 03:08:03 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 13:32:57 UTC) #5
Message was sent while issue was closed. 
Change committed as 262964

Powered by Google App Engine
This is Rietveld 408576698