Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2286423002: chromeos: Remove unused AP manager D-Bus client library (Closed)

Created:
4 years, 3 months ago by James Cook
Modified:
4 years, 3 months ago
Reviewers:
stevenjb, dtapuska
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Remove unused AP manager client libraries These are unused and no longer needed. We can revive them from git history if we need them again. BUG=641996 TEST=compiles Committed: https://crrev.com/283ab821d3c138b0584c3e54de1e0755a069deab Cr-Commit-Position: refs/heads/master@{#415150}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -933 lines) Patch
M chromeos/chromeos.gyp View 1 2 chunks +0 lines, -4 lines 0 comments Download
A chromeos/dbus/README.md View 1 chunk +8 lines, -0 lines 0 comments Download
D chromeos/dbus/ap_manager_client.h View 1 chunk +0 lines, -288 lines 0 comments Download
D chromeos/dbus/ap_manager_client.cc View 1 chunk +0 lines, -491 lines 0 comments Download
M chromeos/dbus/dbus_client_bundle.h View 1 4 chunks +1 line, -6 lines 0 comments Download
M chromeos/dbus/dbus_client_bundle.cc View 1 3 chunks +0 lines, -8 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 1 3 chunks +0 lines, -6 lines 0 comments Download
D chromeos/dbus/fake_ap_manager_client.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chromeos/dbus/fake_ap_manager_client.cc View 1 chunk +0 lines, -78 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
James Cook
dtapuska, please take a look.
4 years, 3 months ago (2016-08-29 17:25:47 UTC) #4
dtapuska
lgtm
4 years, 3 months ago (2016-08-29 17:27:59 UTC) #5
James Cook
stevenjb, can I get OWNERS?
4 years, 3 months ago (2016-08-29 17:31:08 UTC) #8
stevenjb
lgtm, cheers!
4 years, 3 months ago (2016-08-29 17:40:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286423002/1
4 years, 3 months ago (2016-08-29 18:13:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286423002/1
4 years, 3 months ago (2016-08-29 23:59:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286423002/20001
4 years, 3 months ago (2016-08-30 02:45:12 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 05:23:03 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:24:35 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/283ab821d3c138b0584c3e54de1e0755a069deab
Cr-Commit-Position: refs/heads/master@{#415150}

Powered by Google App Engine
This is Rietveld 408576698