DescriptionMove gyp-win-tool to the GN Windows toolchain.
Renames it tool_wrapper.py but otherwise keeps it unchanged from the original
https://chromium.googlesource.com/external/gyp.git/+/master/pylib/gyp/win_tool.py
The copy step of the old tool is currently kept pending a fix to NaCl that references it.
I changed internal references to itself to tool_wrapper.py, and split the internal strings containing the word "Copyright" (which it uses to filter tool output) to avoid triggering the copyright presubmit check.
Changes the build to refer to the file in-place rather than copying it to the build directory which was confusing.
The tool runs itself in the link_manifest step. Since the file is no longer copied to what will be the current directory when linking, I believe this will be broken. But the GN build does not use the manifest linking command. To keep changes minimal, I kept this code in for now.
Reland of http://crrev.com/2287603003 with fixes (keep the tool pending NaCl roll).
BUG=642014
R=scottmg@chromium.org
Committed: https://crrev.com/3826c51de883b9beedc92de5c17e9946a92dfe6d
Cr-Commit-Position: refs/heads/master@{#415034}
Patch Set 1 : Original patch #Patch Set 2 : fix #
Messages
Total messages: 16 (11 generated)
|