Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2286413002: Move gyp-win-tool to the GN Windows toolchain. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move gyp-win-tool to the GN Windows toolchain. Renames it tool_wrapper.py but otherwise keeps it unchanged from the original https://chromium.googlesource.com/external/gyp.git/+/master/pylib/gyp/win_tool.py The copy step of the old tool is currently kept pending a fix to NaCl that references it. I changed internal references to itself to tool_wrapper.py, and split the internal strings containing the word "Copyright" (which it uses to filter tool output) to avoid triggering the copyright presubmit check. Changes the build to refer to the file in-place rather than copying it to the build directory which was confusing. The tool runs itself in the link_manifest step. Since the file is no longer copied to what will be the current directory when linking, I believe this will be broken. But the GN build does not use the manifest linking command. To keep changes minimal, I kept this code in for now. Reland of http://crrev.com/2287603003 with fixes (keep the tool pending NaCl roll). BUG=642014 R=scottmg@chromium.org Committed: https://crrev.com/3826c51de883b9beedc92de5c17e9946a92dfe6d Cr-Commit-Position: refs/heads/master@{#415034}

Patch Set 1 : Original patch #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -15 lines) Patch
M build/config/win/manifest.gni View 3 chunks +5 lines, -5 lines 0 comments Download
M build/toolchain/toolchain.gni View 1 chunk +5 lines, -2 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 7 chunks +11 lines, -6 lines 0 comments Download
M build/toolchain/win/midl.gni View 1 chunk +2 lines, -2 lines 0 comments Download
A build/toolchain/win/tool_wrapper.py View 1 chunk +324 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
brettw
fix
4 years, 3 months ago (2016-08-29 17:13:03 UTC) #1
brettw
4 years, 3 months ago (2016-08-29 17:14:33 UTC) #6
scottmg
lgtm
4 years, 3 months ago (2016-08-29 17:17:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286413002/20001
4 years, 3 months ago (2016-08-29 20:21:36 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 22:09:22 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3826c51de883b9beedc92de5c17e9946a92dfe6d
Cr-Commit-Position: refs/heads/master@{#415034}

Powered by Google App Engine
This is Rietveld 408576698