Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2286393002:
Clean up paint expectations. (Closed)
|
Created:
4 years, 3 months ago by Stephen Chennney Modified:
4 years, 3 months ago Reviewers:
chrishtr CC:
blink-reviews, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionClean up paint expectations.
No change, just re-ordering.
TBR=chrishtr@chromium.org
BUG=636475
Committed: https://crrev.com/079b912c02a8838fbf2f246c3215d359d50df7a5
Cr-Commit-Position: refs/heads/master@{#415422}
Patch Set 1 #Patch Set 2 : Clean up paint expectations. #Messages
Total messages: 16 (9 generated)
Description was changed from ========== Clean up paint expectations. No change, just re-ordering. TBR=chrishtr@chromium.org BUG=636475 ========== to ========== Clean up paint expectations. No change, just re-ordering. NOTRY=true TBR=chrishtr@chromium.org BUG=636475 ==========
The CQ bit was checked by schenney@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:102 Falling back to three-way merge... Applied patch to 'third_party/WebKit/LayoutTests/TestExpectations' with conflicts. U third_party/WebKit/LayoutTests/TestExpectations Patch: third_party/WebKit/LayoutTests/TestExpectations Index: third_party/WebKit/LayoutTests/TestExpectations diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations index 01350f80c6f20cfcb30d953c64a4cb130bd59acf..3517db684e7a9a944cd7941221b631a21ef9eb6d 100644 --- a/third_party/WebKit/LayoutTests/TestExpectations +++ b/third_party/WebKit/LayoutTests/TestExpectations @@ -62,6 +62,9 @@ crbug.com/598051 svg/zoom/page/zoom-foreignObject.svg [ Skip ] crbug.com/601669 [ Win ] svg/as-image/svg-nested.html [ Crash Pass ] +# Fails consistently on WebKit Mac10.10, WebKit Mac10.11 (retina) and mac10.10_blink_rel tryserver, but not on other Mac bots. +crbug.com/614910 [ Mac ] virtual/gpu-rasterization/fast/images/pixel-crack-image-background-webkit-transform-scale.html [ Pass Failure ] + crbug.com/619103 fast/repaint/background-resize-width.html [ Failure ] crbug.com/619103 fast/repaint/hover-invalidation-table.html [ Failure ] crbug.com/619103 fast/repaint/selected-replaced.html [ Failure ] @@ -87,11 +90,6 @@ crbug.com/627782 [ Win ] svg/filters/filter-source-position.svg [ Pass Failure ] crbug.com/630615 [ Win7 ] fast/images/color-profile-background-image-space.html [ Skip ] -crbug.com/638293 [ Linux ] virtual/gpu-rasterization/fast/images/color-profile-reflection.html [ Failure ] - -# Fails consistently on WebKit Mac10.10, WebKit Mac10.11 (retina) and mac10.10_blink_rel tryserver, but not on other Mac bots. -crbug.com/614910 [ Mac ] virtual/gpu-rasterization/fast/images/pixel-crack-image-background-webkit-transform-scale.html [ Pass Failure ] - crbug.com/630967 [ Linux Debug ] svg/parser/whitespace-length-invalid-1.html [ Skip ] crbug.com/630967 [ Linux Debug ] svg/parser/whitespace-length-invalid-2.html [ Skip ] crbug.com/630967 [ Linux Debug ] svg/parser/whitespace-angle.html [ Skip ] @@ -102,16 +100,6 @@ crbug.com/632548 [ Win ] fast/repaint/overflow-scroll-body-appear.html [ Pass Fa crbug.com/632548 [ Win ] fast/repaint/invalidation-after-opacity-change-subtree.html [ Pass Failure ] crbug.com/632548 [ Win ] compositing/overflow/text-match-highlight.html [ Pass Failure ] -crbug.com/636222 [ Mac10.10 ] fast/repaint/fixed-and-absolute-position-scrolled.html [ Failure ] - -crbug.com/636271 [ Mac ] fast/repaint/resize-iframe-text.html [ Pass Failure ] -crbug.com/636271 [ Linux ] fast/repaint/resize-iframe-text.html [ Pass Failure ] -crbug.com/636271 [ Win ] fast/repaint/resize-iframe-text.html [ Pass Failure ] - -crbug.com/639147 svg/wicd/test-rightsizing-b.xhtml [ Failure Pass ] - -# ====== Paint team owned tests to here ====== - crbug.com/635724 paint/selection/selection-in-composited-scrolling-container.html [ NeedsRebaseline ] crbug.com/635724 paint/selection/selection-in-non-composited-scrolling-container.html [ NeedsRebaseline ] crbug.com/635724 paint/invalidation/invalidate-caret-in-composited-scrolling-container.html [ NeedsRebaseline ] @@ -124,6 +112,18 @@ crbug.com/635724 fast/repaint/delete-into-nested-block.html [ NeedsRebaseline ] crbug.com/635724 fast/repaint/inline-outline-repaint.html [ NeedsRebaseline ] crbug.com/635724 fast/repaint/selection-after-delete.html [ NeedsRebaseline ] +crbug.com/636222 [ Mac10.10 ] fast/repaint/fixed-and-absolute-position-scrolled.html [ Failure ] + +crbug.com/636271 [ Mac ] fast/repaint/resize-iframe-text.html [ Pass Failure ] +crbug.com/636271 [ Linux ] fast/repaint/resize-iframe-text.html [ Pass Failure ] +crbug.com/636271 [ Win ] fast/repaint/resize-iframe-text.html [ Pass Failure ] + +crbug.com/638293 [ Linux ] virtual/gpu-rasterization/fast/images/color-profile-reflection.html [ Failure ] + +crbug.com/639147 svg/wicd/test-rightsizing-b.xhtml [ Failure Pass ] + +# ====== Paint team owned tests to here ====== + # Run these tests with under virtual/scalefactor... only. crbug.com/567837 fast/hidpi/static [ Skip ]
The CQ bit was checked by schenney@chromium.org
The CQ bit was unchecked by schenney@chromium.org
Description was changed from ========== Clean up paint expectations. No change, just re-ordering. NOTRY=true TBR=chrishtr@chromium.org BUG=636475 ========== to ========== Clean up paint expectations. No change, just re-ordering. TBR=chrishtr@chromium.org BUG=636475 ==========
The CQ bit was checked by schenney@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Message was sent while issue was closed.
Description was changed from ========== Clean up paint expectations. No change, just re-ordering. TBR=chrishtr@chromium.org BUG=636475 ========== to ========== Clean up paint expectations. No change, just re-ordering. TBR=chrishtr@chromium.org BUG=636475 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Clean up paint expectations. No change, just re-ordering. TBR=chrishtr@chromium.org BUG=636475 ========== to ========== Clean up paint expectations. No change, just re-ordering. TBR=chrishtr@chromium.org BUG=636475 Committed: https://crrev.com/079b912c02a8838fbf2f246c3215d359d50df7a5 Cr-Commit-Position: refs/heads/master@{#415422} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/079b912c02a8838fbf2f246c3215d359d50df7a5 Cr-Commit-Position: refs/heads/master@{#415422}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2299503002/ by yhirano@chromium.org. The reason for reverting is: In spite of the CL description this CL changes the expectation.. |
