Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2286373002: Make clear SupportsRequestPriority() also implies connection sharing. (Closed)

Created:
4 years, 3 months ago by Randy Smith (Not in Mondays)
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make clear SupportsRequestPriority() also implies connection sharing. BUG=637407 R=rch@chromium.org Committed: https://crrev.com/c31e0606bacb84a3766bdcf75e93d044bdbe917e Cr-Commit-Position: refs/heads/master@{#415222}

Patch Set 1 #

Patch Set 2 : Make comment on SupportsRequestPriority more specific. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M net/http/http_server_properties.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Randy Smith (Not in Mondays)
Ryan, PTAL?
4 years, 3 months ago (2016-08-29 16:50:16 UTC) #1
Ryan Hamilton
LGTM!
4 years, 3 months ago (2016-08-29 17:20:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286373002/20001
4 years, 3 months ago (2016-08-29 17:42:02 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 06:27:41 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:29:15 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c31e0606bacb84a3766bdcf75e93d044bdbe917e
Cr-Commit-Position: refs/heads/master@{#415222}

Powered by Google App Engine
This is Rietveld 408576698