X87: [turbofan] Remove special JSForInStep and JSForInDone.

X87: [turbofan] Remove special JSForInStep and JSForInDone.

  port 1915762cc8caea42727daebfe738bfcdca8ac859 (r38968)

  original commit message:
  These JavaScript operators were special hacks to ensure that we always
  operate on Smis for the magic for-in index variable, but this never
  really worked in the OSR case, because the OsrValue for the index
  variable didn't have the proper information (that we have for the
  JSForInPrepare in the non-OSR case).

  Now that we have loop induction variable analysis and binary operation
  hints, we can just use JSLessThan and JSAdd instead with appropriate
  Smi hints, which handle the OSR case by inserting Smi checks (that are
  always true). Thanks to OSR deconstruction and loop peeling these Smi
  checks will be hoisted so they don't hurt the OSR case too much.

  Drive-by-change: Rename the ForInDone bytecode to ForInContinue, since
  we have to lower it to JSLessThan to get the loop induction variable
  goodness.

BUG=

Committed: https://crrev.com/5572cea1d1a02f2b23a805a2baf00c5c1d36441d
Cr-Commit-Position: refs/heads/master@{#38992}

[zhengxing.li, 2016-08-30 03:41:37]

zhengxing.li@intel.com changed reviewers:
+ bmeurer@chromium.org, chunyang.dai@intel.com, weiliang.lin@intel.com

[zhengxing.li, 2016-08-30 03:41:38]

PTAL, thanks!

[Weiliang, 2016-08-30 06:06:19]

lgtm

[zhengxing.li, 2016-08-30 06:07:47]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-08-30 06:07:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 06:29:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-30 06:29:24]

Description was changed from

==========
X87: [turbofan] Remove special JSForInStep and JSForInDone.

  port 1915762cc8caea42727daebfe738bfcdca8ac859 (r38968)

  original commit message:
  These JavaScript operators were special hacks to ensure that we always
  operate on Smis for the magic for-in index variable, but this never
  really worked in the OSR case, because the OsrValue for the index
  variable didn't have the proper information (that we have for the
  JSForInPrepare in the non-OSR case).

  Now that we have loop induction variable analysis and binary operation
  hints, we can just use JSLessThan and JSAdd instead with appropriate
  Smi hints, which handle the OSR case by inserting Smi checks (that are
  always true). Thanks to OSR deconstruction and loop peeling these Smi
  checks will be hoisted so they don't hurt the OSR case too much.

  Drive-by-change: Rename the ForInDone bytecode to ForInContinue, since
  we have to lower it to JSLessThan to get the loop induction variable
  goodness.

BUG=
==========

to

==========
X87: [turbofan] Remove special JSForInStep and JSForInDone.

  port 1915762cc8caea42727daebfe738bfcdca8ac859 (r38968)

  original commit message:
  These JavaScript operators were special hacks to ensure that we always
  operate on Smis for the magic for-in index variable, but this never
  really worked in the OSR case, because the OsrValue for the index
  variable didn't have the proper information (that we have for the
  JSForInPrepare in the non-OSR case).

  Now that we have loop induction variable analysis and binary operation
  hints, we can just use JSLessThan and JSAdd instead with appropriate
  Smi hints, which handle the OSR case by inserting Smi checks (that are
  always true). Thanks to OSR deconstruction and loop peeling these Smi
  checks will be hoisted so they don't hurt the OSR case too much.

  Drive-by-change: Rename the ForInDone bytecode to ForInContinue, since
  we have to lower it to JSLessThan to get the loop induction variable
  goodness.

BUG=

Committed: https://crrev.com/5572cea1d1a02f2b23a805a2baf00c5c1d36441d
Cr-Commit-Position: refs/heads/master@{#38992}
==========

[commit-bot: I haz the power, 2016-08-30 06:29:25]

Patchset 1 (id:??) landed as
https://crrev.com/5572cea1d1a02f2b23a805a2baf00c5c1d36441d
Cr-Commit-Position: refs/heads/master@{#38992}