Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2286353002: Use FormatPercent() in PowerStatusView (Closed)

Created:
4 years, 3 months ago by Greg Levin
Modified:
4 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, jungshik at Google
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FormatPercent() in PowerStatusView BUG=612181 TEST=Should be no difference in battery percent display in SysTray menu Small cleanup from prior i18n work Committed: https://crrev.com/a32e6d4c2800569bb486287fdbd17e6918d1d2d0 Cr-Commit-Position: refs/heads/master@{#415129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ash/common/system/chromeos/power/power_status_view.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Greg Levin
Please have a look! NOTE: This is a small change that I wanted to do ...
4 years, 3 months ago (2016-08-29 16:09:23 UTC) #2
stevenjb
lgtm
4 years, 3 months ago (2016-08-29 16:34:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286353002/1
4 years, 3 months ago (2016-08-29 19:52:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 05:01:23 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:05:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a32e6d4c2800569bb486287fdbd17e6918d1d2d0
Cr-Commit-Position: refs/heads/master@{#415129}

Powered by Google App Engine
This is Rietveld 408576698