Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2286343003: Make --enable-slimming-paint-v2 enable --enable-layer-lists (Closed)

Created:
4 years, 3 months ago by pdr.
Modified:
4 years, 3 months ago
Reviewers:
chrishtr, no sievers, trchen
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make --enable-slimming-paint-v2 enable --enable-layer-lists With this patch, enabling SlimmingPaintV2 will automatically enable enable-layer-lists. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 BUG=630691 Committed: https://crrev.com/4cd50edf73839959f775daa562e209d3802dd64f Cr-Commit-Position: refs/heads/master@{#415508}

Patch Set 1 #

Patch Set 2 : File bugs and update expectations #

Total comments: 1

Patch Set 3 : Spell Fail properly: Failure #

Patch Set 4 : Add additional crashes from the bot #

Patch Set 5 : One more small update #

Total comments: 2

Patch Set 6 : Braces! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -10 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 2 3 4 7 chunks +47 lines, -10 lines 0 comments Download

Messages

Total messages: 38 (25 generated)
pdr.
4 years, 3 months ago (2016-08-30 17:21:43 UTC) #9
pdr.
https://codereview.chromium.org/2286343003/diff/20001/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 (left): https://codereview.chromium.org/2286343003/diff/20001/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2#oldcode475 third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:475: compositing/video/video-reflection.html [ Failure ] This was a mistake in ...
4 years, 3 months ago (2016-08-30 17:31:48 UTC) #13
chrishtr
lgtm
4 years, 3 months ago (2016-08-30 20:32:40 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286343003/80001
4 years, 3 months ago (2016-08-30 20:42:25 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/249587)
4 years, 3 months ago (2016-08-30 20:47:46 UTC) #25
pdr.
sievers, could you please review this with your content/OWNERS superpowers?
4 years, 3 months ago (2016-08-30 20:50:43 UTC) #27
no sievers
lgtm https://codereview.chromium.org/2286343003/diff/80001/content/browser/renderer_host/render_process_host_impl.cc File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/2286343003/diff/80001/content/browser/renderer_host/render_process_host_impl.cc#newcode1482 content/browser/renderer_host/render_process_host_impl.cc:1482: switches::kEnableSlimmingPaintV2)) nit: curly braces since it's multiline
4 years, 3 months ago (2016-08-30 20:55:01 UTC) #28
trchen
The CL title doesn't match CL desc. Other than that lgtm. Yay!
4 years, 3 months ago (2016-08-30 21:41:14 UTC) #29
pdr.
https://codereview.chromium.org/2286343003/diff/80001/content/browser/renderer_host/render_process_host_impl.cc File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/2286343003/diff/80001/content/browser/renderer_host/render_process_host_impl.cc#newcode1482 content/browser/renderer_host/render_process_host_impl.cc:1482: switches::kEnableSlimmingPaintV2)) On 2016/08/30 at 20:55:01, sievers wrote: > nit: ...
4 years, 3 months ago (2016-08-30 22:31:05 UTC) #30
pdr.
On 2016/08/30 at 21:41:14, trchen wrote: > The CL title doesn't match CL desc. Other ...
4 years, 3 months ago (2016-08-30 22:33:27 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286343003/100001
4 years, 3 months ago (2016-08-30 22:34:25 UTC) #35
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 3 months ago (2016-08-31 00:17:43 UTC) #36
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 00:21:15 UTC) #38
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/4cd50edf73839959f775daa562e209d3802dd64f
Cr-Commit-Position: refs/heads/master@{#415508}

Powered by Google App Engine
This is Rietveld 408576698