|
|
Chromium Code Reviews
DescriptionMake --enable-slimming-paint-v2 enable --enable-layer-lists
With this patch, enabling SlimmingPaintV2 will automatically enable
enable-layer-lists.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
BUG=630691
Committed: https://crrev.com/4cd50edf73839959f775daa562e209d3802dd64f
Cr-Commit-Position: refs/heads/master@{#415508}
Patch Set 1 #Patch Set 2 : File bugs and update expectations #
Total comments: 1
Patch Set 3 : Spell Fail properly: Failure #Patch Set 4 : Add additional crashes from the bot #Patch Set 5 : One more small update #
Total comments: 2
Patch Set 6 : Braces! #
Messages
Total messages: 38 (25 generated)
The CQ bit was checked by pdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Make --enable-layer-lists imply --enable-slimming-paint-v2 With this patch, enabling SlimmingPaintV2 will automatically enable enable-layer-lists. BUG=630691 ========== to ========== Make --enable-layer-lists imply --enable-slimming-paint-v2 With this patch, enabling SlimmingPaintV2 will automatically enable enable-layer-lists. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v BUG=630691 ==========
pdr@chromium.org changed reviewers: + chrishtr@chromium.org, trchen@chromium.org
The CQ bit was checked by pdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_slimming_paint_v on master.tryserver.chromium.linux (JOB_FAILED, no build URL)
Description was changed from ========== Make --enable-layer-lists imply --enable-slimming-paint-v2 With this patch, enabling SlimmingPaintV2 will automatically enable enable-layer-lists. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v BUG=630691 ========== to ========== Make --enable-layer-lists imply --enable-slimming-paint-v2 With this patch, enabling SlimmingPaintV2 will automatically enable enable-layer-lists. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 BUG=630691 ==========
https://codereview.chromium.org/2286343003/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 (left): https://codereview.chromium.org/2286343003/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:475: compositing/video/video-reflection.html [ Failure ] This was a mistake in https://crrev.com/a52eb4201de9237701af410cb1d5c38a88373e58, just tidying it up here.
The CQ bit was checked by pdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by pdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by pdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by pdr@chromium.org
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
pdr@chromium.org changed reviewers: + sievers@chromium.org
sievers, could you please review this with your content/OWNERS superpowers?
lgtm https://codereview.chromium.org/2286343003/diff/80001/content/browser/rendere... File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/2286343003/diff/80001/content/browser/rendere... content/browser/renderer_host/render_process_host_impl.cc:1482: switches::kEnableSlimmingPaintV2)) nit: curly braces since it's multiline
The CL title doesn't match CL desc. Other than that lgtm. Yay!
https://codereview.chromium.org/2286343003/diff/80001/content/browser/rendere... File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/2286343003/diff/80001/content/browser/rendere... content/browser/renderer_host/render_process_host_impl.cc:1482: switches::kEnableSlimmingPaintV2)) On 2016/08/30 at 20:55:01, sievers wrote: > nit: curly braces since it's multiline Good idea, done.
Description was changed from ========== Make --enable-layer-lists imply --enable-slimming-paint-v2 With this patch, enabling SlimmingPaintV2 will automatically enable enable-layer-lists. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 BUG=630691 ========== to ========== Make --enable-slimming-paint-v2 enable --enable-layer-lists With this patch, enabling SlimmingPaintV2 will automatically enable enable-layer-lists. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 BUG=630691 ==========
On 2016/08/30 at 21:41:14, trchen wrote: > The CL title doesn't match CL desc. Other than that lgtm. Yay! Good catch, I switched this to "Make --enable-slimming-paint-v2 enable --enable-layer-lists".
The CQ bit was checked by pdr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from chrishtr@chromium.org, sievers@chromium.org, trchen@chromium.org Link to the patchset: https://codereview.chromium.org/2286343003/#ps100001 (title: "Braces!")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Make --enable-slimming-paint-v2 enable --enable-layer-lists With this patch, enabling SlimmingPaintV2 will automatically enable enable-layer-lists. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 BUG=630691 ========== to ========== Make --enable-slimming-paint-v2 enable --enable-layer-lists With this patch, enabling SlimmingPaintV2 will automatically enable enable-layer-lists. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 BUG=630691 Committed: https://crrev.com/4cd50edf73839959f775daa562e209d3802dd64f Cr-Commit-Position: refs/heads/master@{#415508} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/4cd50edf73839959f775daa562e209d3802dd64f Cr-Commit-Position: refs/heads/master@{#415508} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
