Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2286333002: win_tools.bat: call git_bootstrap.py, remove deprecated svn bootstrap (Closed)

Created:
4 years, 3 months ago by Paweł Hajdan Jr.
Modified:
4 years, 3 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -148 lines) Patch
M bootstrap/win/win_tools.bat View 1 chunk +1 line, -148 lines 2 comments Download

Messages

Total messages: 14 (9 generated)
tandrii(chromium)
LGTM if works :) https://codereview.chromium.org/2286333002/diff/1/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/2286333002/diff/1/bootstrap/win/win_tools.bat#newcode70 bootstrap/win/win_tools.bat:70: "%WIN_TOOLS_ROOT_DIR%\python.bat" "%~dp0git_bootstrap.py" --bits "%OS_BITS%" if ...
4 years, 3 months ago (2016-08-29 14:38:29 UTC) #6
tandrii(chromium)
lgtm https://codereview.chromium.org/2286333002/diff/1/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/2286333002/diff/1/bootstrap/win/win_tools.bat#newcode70 bootstrap/win/win_tools.bat:70: "%WIN_TOOLS_ROOT_DIR%\python.bat" "%~dp0git_bootstrap.py" --bits "%OS_BITS%" On 2016/08/29 14:38:29, tandrii(chromium) ...
4 years, 3 months ago (2016-08-29 14:47:29 UTC) #9
tandrii(chromium)
lgtm lgtm https://codereview.chromium.org/2286333002/diff/1/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/2286333002/diff/1/bootstrap/win/win_tools.bat#newcode70 bootstrap/win/win_tools.bat:70: "%WIN_TOOLS_ROOT_DIR%\python.bat" "%~dp0git_bootstrap.py" --bits "%OS_BITS%" On 2016/08/29 14:38:29, ...
4 years, 3 months ago (2016-08-29 14:47:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286333002/1
4 years, 3 months ago (2016-08-29 14:47:35 UTC) #11
Paweł Hajdan Jr.
4 years, 3 months ago (2016-08-29 14:49:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
42ffe773c3b7d4890dcd0d0d3f8471089daac9e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698