Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2286323004: Remove vector_icons.gypi (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove vector_icons.gypi Moves the target from //ui/gfx:vector_icons_generate to //ui/gfx/vector_icons/* Adds the templates to the inputs of the generate script so it re-runs when the templates change (this was a bug in the previous implementation). Committed: https://crrev.com/bb97acc2da3b2671489dfd303bd2664e2ddb1651 Cr-Commit-Position: refs/heads/master@{#415153}

Patch Set 1 #

Patch Set 2 : Missing includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -288 lines) Patch
M ash/common/wm/overview/window_selector.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/overview/window_selector_item.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 3 chunks +1 line, -35 lines 0 comments Download
M ui/gfx/paint_vector_icon.cc View 1 chunk +1 line, -1 line 0 comments Download
A ui/gfx/vector_icons/BUILD.gn View 1 chunk +282 lines, -0 lines 0 comments Download
M ui/gfx/vector_icons/vector_icons.cc.template View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/vector_icons/vector_icons.h.template View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/vector_icons_public.h View 1 chunk +1 line, -1 line 0 comments Download
D ui/gfx/vector_icons_sources.gypi View 1 chunk +0 lines, -244 lines 0 comments Download
M ui/views/style/platform_style_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
brettw
4 years, 3 months ago (2016-08-29 19:53:52 UTC) #2
sky
LGTM
4 years, 3 months ago (2016-08-29 19:59:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286323004/1
4 years, 3 months ago (2016-08-29 20:53:11 UTC) #8
brettw
Missing includes
4 years, 3 months ago (2016-08-29 22:01:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286323004/20001
4 years, 3 months ago (2016-08-29 22:26:32 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 05:25:52 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:28:59 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb97acc2da3b2671489dfd303bd2664e2ddb1651
Cr-Commit-Position: refs/heads/master@{#415153}

Powered by Google App Engine
This is Rietveld 408576698